All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: Naphtali Sprei <nsprei@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [qemu-kvm tests PATCH v2 2/3] qemu-kvm tests cleanup: adapt stringio test to kernel-mode run
Date: Tue, 27 Apr 2010 16:03:07 +0300	[thread overview]
Message-ID: <20100427130307.GG10044@redhat.com> (raw)
In-Reply-To: <1272373065-3162-3-git-send-email-nsprei@redhat.com>

On Tue, Apr 27, 2010 at 03:57:44PM +0300, Naphtali Sprei wrote:
> Also use testdev for output, call exit to quit.
> Currently, test reboots endlessly because of a triple-fault.
> Need to run test with -no-reboot till issue fixed (in kvm ??)
> 
Rewriting this in C would be nice. May be adding this as additional test into
emulator.c
 
> Signed-off-by: Naphtali Sprei <nsprei@redhat.com>
> ---
>  kvm/user/config-x86-common.mak |    2 +-
>  kvm/user/test/x86/stringio.S   |   13 +++++++++----
>  2 files changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/kvm/user/config-x86-common.mak b/kvm/user/config-x86-common.mak
> index 960741e..d312681 100644
> --- a/kvm/user/config-x86-common.mak
> +++ b/kvm/user/config-x86-common.mak
> @@ -54,7 +54,7 @@ $(TEST_DIR)/realmode.flat: $(TEST_DIR)/realmode.o
>  
>  $(TEST_DIR)/realmode.o: bits = 32
>  
> -$(TEST_DIR)/stringio.flat: $(TEST_DIR)/stringio.o
> +$(TEST_DIR)/stringio.flat: $(cstart.o) $(TEST_DIR)/stringio.o
>  
>  $(TEST_DIR)/msr.flat: $(cstart.o) $(TEST_DIR)/msr.o
>  
> diff --git a/kvm/user/test/x86/stringio.S b/kvm/user/test/x86/stringio.S
> index 31ddc47..461621c 100644
> --- a/kvm/user/test/x86/stringio.S
> +++ b/kvm/user/test/x86/stringio.S
> @@ -8,24 +8,29 @@
>  1:	
>  .endm	
>  
> +TESTDEV_PORT = 0xf1
> +
>  	str "forward", "forward"
>  	str "backward", "backward"
>  		
>  .text
>  
> -
> +.global main
> +main:
>  	cld
>  	movl forward, %ecx
>  	lea  4+forward, %rsi
> -	movw $1, %dx
> +	movw $TESTDEV_PORT, %dx
>  	rep outsb
>  
>  	std
>  	movl backward, %ecx
>  	lea 4+backward-1(%rcx), %rsi
> -	movw $2, %dx
> +	movw $TESTDEV_PORT, %dx
>  	rep outsb
>  	
> -	hlt
> +	mov $0, %rsi
> +	call exit
> +
>  
>  
> -- 
> 1.6.3.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
			Gleb.

  parent reply	other threads:[~2010-04-27 13:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27 12:57 [qemu-kvm tests PATCH v2 0/3] qemu-kvm tests cleanup Naphtali Sprei
2010-04-27 12:57 ` [qemu-kvm tests PATCH v2 1/3] " Naphtali Sprei
2010-04-27 12:57   ` [qemu-kvm tests PATCH v2 2/3] qemu-kvm tests cleanup: adapt stringio test to kernel-mode run Naphtali Sprei
2010-04-27 12:57     ` [qemu-kvm tests PATCH v2 3/3] qemu-kvm tests cleanup: Added printing for passing tests Also typo fix Naphtali Sprei
2010-04-27 13:03     ` Gleb Natapov [this message]
2010-04-30 20:13 ` [qemu-kvm tests PATCH v2 0/3] qemu-kvm tests cleanup Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100427130307.GG10044@redhat.com \
    --to=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=nsprei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.