Re: [PATCH] classmate-laptop: Add RFKILL support.

[Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

On Tue, Apr 27, 2010 at 05:22:27PM +0100, Matthew Garrett wrote:
> On Tue, Apr 27, 2010 at 01:15:00PM -0300, Thadeu Lima de Souza Cascardo wrote:
> > The RFKILL device shares the same ACPI device used for backlight. So, it
> > required a new struct sharing both a backlight_device and a rfkill
> > device.
> 
> Is this purely a software-controlled toggle, or can the firmware change 
> the state as well? If the latter, how is synchronisation between 
> hardware and OS state handled?
> 
> -- 
> Matthew Garrett | mjg59@srcf.ucam.org

It's purely a soft block device. I'll add that in the commit message
with any other changes suggested or requested.

I'd really like some feedback about the implementation. I've done tests
around here, but I may still have gotten something wrong. And I sure
hope I haven't messed with the backlight. But nothing points that I've
done so.

Anyway, I'd like some review.

Thanks,
Cascardo.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]