Re: [PATCH 2/2] cdrom_id: only mark sr[0-9]* as ID_CDROM

[Martin Pitt <martin.pitt@ubuntu.com>]

Hello Harald,

harald@redhat.com [2010-04-27 12:26 +0200]:
> diff --git a/extras/cdrom_id/60-cdrom_id.rules b/extras/cdrom_id/60-cdrom_id.rules
> index 16b3af9..b3109f1 100644
> --- a/extras/cdrom_id/60-cdrom_id.rules
> +++ b/extras/cdrom_id/60-cdrom_id.rules
> @@ -5,7 +5,7 @@ SUBSYSTEM!="block", GOTO="cdrom_end"
>  KERNEL!="sr[0-9]*|xvd*", GOTO="cdrom_end"
>  ENV{DEVTYPE}!="disk", GOTO="cdrom_end"
>  
> -ENV{ID_CDROM}="1"
> +KERNEL="sr[0-9]*", ENV{ID_CDROM}="1"

This would require the distros/platforms (such as some powerpc) which
still use the IDE CD driver to adapt this as well (which shouldn't be
a big deal, but they need to know, since patches to adapt the first
rule might still apply cleanly)

I wonder why we need this at all. cdrom_id already sets ID_CDROM once
it figured out that it is a drive. Was this added for cases where
cdrom_id failed (we recently fixed a ton of bugs in it)? Or for the
case where you build without extras?

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)