All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] jbd: Provide function to check whether transaction will issue data barrier
Date: Tue, 27 Apr 2010 22:48:31 +0200	[thread overview]
Message-ID: <20100427204831.GD5103@quack.suse.cz> (raw)
In-Reply-To: <87eii1d0hy.fsf@openvz.org>

On Tue 27-04-10 07:42:49, Dmitry Monakhov wrote:
> Jan Kara <jack@suse.cz> writes:
> 
> > Provide a function which returns whether a transaction with given tid
> > will send a barrier to the filesystem device. The function will be used
> > by ext3 to detect whether fsync needs to send a separate barrier or not.
> Agree. Except the fact that in case of j_dev != j_fs_dev jbd is still
> broken.
  Yeah, I know about this. I had a look at it but stumbled over a barrier
issue in the checkpointing code
(http://marc.info/?l=linux-ext4&m=127198235617788&w=2) so I though I'll
wait till that gets resolved.

> I'm plan to post back-port from jbd2 which makes
> journal_trans_will_send_data_barrier() more complex. It have to analyze
> commit_transaction->t_flushed_data_blocks.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2010-04-27 20:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-26 20:10 [PATCH 0/2] Fix waiting on transaction in ext3_sync_file Jan Kara
2010-04-26 20:10 ` [PATCH 1/2] jbd: Provide function to check whether transaction will issue data barrier Jan Kara
2010-04-27  3:42   ` Dmitry Monakhov
2010-04-27 20:48     ` Jan Kara [this message]
2010-04-26 20:10 ` [PATCH 2/2] ext3: Fix waiting on transaction during fsync Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100427204831.GD5103@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=dmonakhov@openvz.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.