All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, Scott Smedley <ss@aao.gov.au>,
	Greg KH <gregkh@suse.de>, Jason Baldus <jason.baldus@gmail.com>,
	linux-kernel@vger.kernel.org,
	Harley Sweeten <hsweeten@visionengravers.com>,
	Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH 1/3] drivers/staging/dt3155: Integrate 3 badly styled files into 1 clean file
Date: Tue, 27 Apr 2010 16:02:28 -0700	[thread overview]
Message-ID: <20100427230228.GB17260@kroah.com> (raw)
In-Reply-To: <ba7a1e2464417043f00f78f6ddaab260c23c3cc9.1269847733.git.joe@perches.com>

On Mon, Mar 29, 2010 at 12:34:28AM -0700, Joe Perches wrote:
> Make variables static where appropriate
> Rename dt3155_<foo_with_long_names> variables to dt_<foo_tla>
> to reduce code length and make more lines fit well in 80 chars
> Remove now unnecessary .h files
> Change indent to use tabs
> Remove unused functions
> Used bool more often
> Checkpatch clean

This is too much in one patch, sorry.  It also doesn't apply due to
other changes in these files (that you then remove in patch 3) from
other developers.

thanks,

greg k-h

  reply	other threads:[~2010-04-27 23:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-28 15:26 Staging: dt3155: fixed some checkpatch.pl warnings and errors in dt3155_drv.c Olimpiu Pascariu
2010-03-29  3:23 ` Simon Horman
2010-03-29  7:34   ` [PATCH 0/3] drivers/staging/dt3155: Large cleanups Joe Perches
2010-03-29  7:34     ` [PATCH 1/3] drivers/staging/dt3155: Integrate 3 badly styled files into 1 clean file Joe Perches
2010-04-27 23:02       ` Greg KH [this message]
2010-04-28  5:30         ` Joe Perches
2010-04-28  5:34           ` Greg KH
2010-04-28  5:44             ` Joe Perches
2010-04-28  5:52               ` Greg KH
2010-04-28  6:00                 ` Joe Perches
2010-04-28 16:12                   ` Valdis.Kletnieks
2010-04-28 16:33                     ` Joe Perches
2010-04-28 17:22                       ` Greg KH
2010-04-28 12:18         ` Dan Carpenter
2010-03-29  7:34     ` [PATCH 2/3] drivers/staging/dt3155/allocator: sparse cleanups Joe Perches
2010-03-29  7:34     ` [PATCH 3/3] drivers/staging/dt3155: Remove old files Joe Perches
2010-03-29 17:35   ` Staging: dt3155: fixed some checkpatch.pl warnings and errors in dt3155_drv.c Olimpiu Pascariu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100427230228.GB17260@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=horms@verge.net.au \
    --cc=hsweeten@visionengravers.com \
    --cc=jason.baldus@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ss@aao.gov.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.