All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>, KVM list <kvm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/10] KVM MMU: allow more shadow pages become asynchronous
Date: Wed, 28 Apr 2010 14:12:37 -0300	[thread overview]
Message-ID: <20100428171237.GF18168@amt.cnet> (raw)
In-Reply-To: <4BD7B177.9020003@cn.fujitsu.com>

On Wed, Apr 28, 2010 at 11:54:31AM +0800, Xiao Guangrong wrote:
> Changlog v3:
> 
> Those changes all form Avi's suggestion, thanks.
> 
> - use smart way to fix the bug in patch 1
> - remove duplicates code in patch 5
> - check error code and fix forgot release page in patch 9
> - sync shadow pages in a batch instead of one by one
> 
> And, there is one TODO thing:
> Marker shadow page as unsync at create time avoid write-protect,
> this idea is from Avi:
> 
> |Another interesting case is to create new shadow pages in the unsync state.
> |That can help when the guest starts a short lived process: we can avoid write
> |protecting its pagetables completely
> 
> I'll send the patch out after this patchset applied.
>  
> Changlog v2:
> 
> - when level is PT_DIRECTORY_LEVEL, the 'offset' should be
>   'role.quadrant << 8', thanks Avi for point it out
> 
> - keep invlpg code in paging_tmpl.h address Avi's suggestion
> 
> - split kvm_sync_page() into kvm_sync_page() and kvm_sync_page_transient()
>   to clarify the code address Avi's suggestion

Applied, thanks.


      parent reply	other threads:[~2010-04-28 17:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-28  3:54 [PATCH v3 0/10] KVM MMU: allow more shadow pages become asynchronous Xiao Guangrong
2010-04-28 10:37 ` Avi Kivity
2010-04-28 17:12 ` Marcelo Tosatti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100428171237.GF18168@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiaoguangrong@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.