From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: amit.shah@redhat.com, quintela@redhat.com, kraxel@redhat.com,
kvm@vger.kernel.org
Subject: Re: [PATCHv2] qemu-kvm: fix crash on reboot with vhost-net
Date: Wed, 28 Apr 2010 14:43:05 -0300 [thread overview]
Message-ID: <20100428174304.GI18168@amt.cnet> (raw)
In-Reply-To: <20100428092738.GA32184@redhat.com>
On Wed, Apr 28, 2010 at 12:27:38PM +0300, Michael S. Tsirkin wrote:
> When vhost-net is disabled on reboot, we set msix mask notifier
> to NULL to disable further mask/unmask notifications.
> Code currently tries to pass this NULL to notifier,
> leading to a crash. The right thing to do is
> to add explicit APIs to enable/disable notifications.
> Now when disabling notifications:
> - if vector is masked, we don't need to notify backend,
> just disable future notifications
> - if vector is unmasked, invoke callback to unassign backend,
> then disable future notifications
>
> This patch also polls notifier before closing it,
> to make sure we don't lose events if poll callback
> didn't have time to run.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Applied, thanks.
next prev parent reply other threads:[~2010-04-28 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 9:27 [PATCHv2] qemu-kvm: fix crash on reboot with vhost-net Michael S. Tsirkin
2010-04-28 10:03 ` Juan Quintela
2010-04-28 17:43 ` Marcelo Tosatti [this message]
2010-04-28 20:05 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428174304.GI18168@amt.cnet \
--to=mtosatti@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.