From: Greg KH <greg@kroah.com>
To: Lars Lindley <lindley@coyote.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
gregkh@suse.de, pavel@ucw.cz, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
Date: Wed, 28 Apr 2010 15:56:56 -0700 [thread overview]
Message-ID: <20100428225656.GE24604@kroah.com> (raw)
In-Reply-To: <4BA2A68D.9050401@coyote.org>
On Thu, Mar 18, 2010 at 11:17:49PM +0100, Lars Lindley wrote:
> On 2010-03-18 17:28, Pekka Enberg wrote:
> > Lars Lindley wrote:
> >> I fixed all problems found by checkpatch.pl and removed CamelCase
> >> from argument names.
> ..snip..
> >> +void MLME_GetNextPacket(struct wbsoft_priv *adapter,
> >> + struct wb35_descriptor *pdes);
> >
> > Can we get rid of the "p" prefix (hungarian notation) while at it?
> >
> Sure..
> I changed pdes to des, pmmpdu to mmpdu and widx to idx.
> Looks all right?
>
> /Lars
>
>
>
> Here is the new patch against master:
>
> [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes.
>
> I fixed all problems found by checkpatch.pl and removed CamelCase
> and hungarian notation from the argument names.
>
> Signed-off-by: Lars Lindley <lindley@coyote.org>
This one didn't apply for some reason :(
Care to redo it against linux-next tomorrow?
thanks,
greg k-h
prev parent reply other threads:[~2010-04-28 23:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 15:57 [PATCH] staging: winbond: mlmetxrx_f.h Coding style fixes Lars Lindley
2010-03-18 16:28 ` Pekka Enberg
2010-03-18 22:17 ` Lars Lindley
2010-03-19 5:44 ` Pekka Enberg
2010-03-21 7:00 ` Pavel Machek
2010-04-28 22:56 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428225656.GE24604@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.