From: Dave Chinner <david@fromorbit.com>
To: Tao Ma <tao.ma@oracle.com>
Cc: Eric Sandeen <sandeen@redhat.com>, Alex Elder <aelder@sgi.com>,
Christoph Hellwig <hch@lst.de>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: Add query fiemap count test.
Date: Thu, 29 Apr 2010 15:35:14 +1000 [thread overview]
Message-ID: <20100429053514.GA3774@dastard> (raw)
In-Reply-To: <1272437450-4654-1-git-send-email-tao.ma@oracle.com>
On Wed, Apr 28, 2010 at 02:50:50PM +0800, Tao Ma wrote:
> According to Documentation/filesystems/fiemap.txt, If fm_extent_count
> is zero, then the fm_extents[] array is ignored (no extents will be
> returned), and the fm_mapped_extents count will hold the number of
> extents needed.
>
> This is broken by commit 97db39a1f6f69e906e98118392400de5217aa33a.
> So add this test case in fiemap tester to avoid future regression.
>
> Cc: Dave Chinner <david@fromorbit.com>
> Cc: Eric Sandeen <sandeen@redhat.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Alex Elder <aelder@sgi.com>
> Signed-off-by: Tao Ma <tao.ma@oracle.com>
Looks ok. Just running for a test and if I don't see any problems,
then I'll check it in. Thanks for the fix and the test, Tao. ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-04-29 5:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 6:17 [PATCH] XFS: Let the broken fiemap work in query mode Tao Ma
2010-04-27 6:17 ` Tao Ma
2010-04-28 1:50 ` Dave Chinner
2010-04-28 1:50 ` Dave Chinner
2010-04-28 2:00 ` Tao Ma
2010-04-28 2:00 ` Tao Ma
2010-04-28 2:30 ` Dave Chinner
2010-04-28 2:30 ` Dave Chinner
2010-04-28 3:00 ` [PATCH v2] " Tao Ma
2010-04-28 3:00 ` Tao Ma
2010-04-28 11:33 ` Christoph Hellwig
2010-04-28 11:33 ` Christoph Hellwig
2010-04-28 14:39 ` [PATCH v3] " Tao Ma
2010-04-28 14:39 ` Tao Ma
2010-04-28 6:50 ` [PATCH] xfstests: Add query fiemap count test Tao Ma
2010-04-29 5:35 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100429053514.GA3774@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=hch@lst.de \
--cc=sandeen@redhat.com \
--cc=tao.ma@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.