Re: mmc: sdhci.h compile error

[Anton Vorontsov <cbouatmailru@gmail.com>]

On Thu, Apr 29, 2010 at 03:28:56PM -0700, Andrew Morton wrote:
> On Mon, 26 Apr 2010 14:17:04 +0400
> Anton Vorontsov <cbouatmailru@gmail.com> wrote:
> 
> > On Sun, Apr 25, 2010 at 11:28:17PM +0100, Matt Fleming wrote:
> > > On Wed, 21 Apr 2010 19:43:32 +0800, zhangfei gao <zhangfei.gao@gmail.com> wrote:
> > > > 
> > > > There is compile error when we enable CONFIG_MMC_SDHCI_IO_ACCESSORS,
> > > > and include header file #include "sdhci.h"
> > > > error: macro "writel" passed 3 arguments, but takes just 2
> > > > 
> > > 
> > > Interesting...
> > > 
> > > It was Anton Vorontsov that added this code; presumably the code has
> > > never been compiled for an ARM board (or any other architecture that
> > > #define's their I/O accessors in asm/io.h).
> > 
> > Yep, there wasn't any need for these accessors on other platforms.
> > 
> > > It would be better if all architectures declared their I/O accessors as
> > > static inline, but I'm not volunteering to touch all those headers ;-)
> > > Renaming the SDHCI ops is definitely the easiest option. Anton, do you
> > > have a problem with the attached patch to rename the SDHCI accessor
> > > functions?
> > 
> > Looks OK.
> > 
> > Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
> > (for -next, I presume)
> 
> Why not for 2.6.34?

Because in 2.6.34 there are only PowerPC-specific drivers select
SDHCI_IO_ACCESORS, and for PowerPC there is no problem with
{write,read}{l,w,b} names.

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2