From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Fri, 30 Apr 2010 07:43:43 +0000 Subject: Re: [PATCH 5/5] fsl-diu-fb: Support setting display mode using EDID Message-Id: <20100430094343.2a504b2a@wker> List-Id: References: <1272584978-19063-1-git-send-email-agust@denx.de> <1272584978-19063-6-git-send-email-agust@denx.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Timur Tabi Cc: linux-fbdev@vger.kernel.org, wd@denx.de, dzu@denx.de, devicetree-discuss@lists.ozlabs.org, linuxppc-dev@ozlabs.org, yorksun@freescale.com On Thu, 29 Apr 2010 20:44:12 -0500 Timur Tabi wrote: > On Thu, Apr 29, 2010 at 6:49 PM, Anatolij Gustschin wrote: > > > +Optional properties: > > +- EDID : verbatim EDID data block describing attached display. > > +  Data from the detailed timing descriptor will be used to > > +  program the display controller. > > The property name should be lower-case. Will change to lower-case. > >  /* > >  * These parameters give default parameters > > @@ -217,6 +218,7 @@ struct mfb_info { > >        int x_aoi_d;            /* aoi display x offset to physical screen */ > >        int y_aoi_d;            /* aoi display y offset to physical screen */ > >        struct fsl_diu_data *parent; > > +       char *edid_data; > > edid_data should be "u8 *". "char *" is should be used only for > strings or arrays of characters. Will fix it, too. > > +       /* Still not found, use preferred mode from database if any */ > > +       if (!has_default_mode && info->monspecs.modedb != NULL) { > > No need for the "!= NULL" Ok, I will simplify this. Thanks, Anatolij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by ozlabs.org (Postfix) with ESMTP id C8BE2B7D24 for ; Fri, 30 Apr 2010 17:43:46 +1000 (EST) Date: Fri, 30 Apr 2010 09:43:43 +0200 From: Anatolij Gustschin To: Timur Tabi Subject: Re: [PATCH 5/5] fsl-diu-fb: Support setting display mode using EDID Message-ID: <20100430094343.2a504b2a@wker> In-Reply-To: References: <1272584978-19063-1-git-send-email-agust@denx.de> <1272584978-19063-6-git-send-email-agust@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: linux-fbdev@vger.kernel.org, wd@denx.de, dzu@denx.de, devicetree-discuss@lists.ozlabs.org, linuxppc-dev@ozlabs.org, yorksun@freescale.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 29 Apr 2010 20:44:12 -0500 Timur Tabi wrote: > On Thu, Apr 29, 2010 at 6:49 PM, Anatolij Gustschin wrote: >=20 > > +Optional properties: > > +- EDID : verbatim EDID data block describing attached display. > > + =C2=A0Data from the detailed timing descriptor will be used to > > + =C2=A0program the display controller. >=20 > The property name should be lower-case. Will change to lower-case. > > =C2=A0/* > > =C2=A0* These parameters give default parameters > > @@ -217,6 +218,7 @@ struct mfb_info { > > =C2=A0 =C2=A0 =C2=A0 =C2=A0int x_aoi_d; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0/* aoi display x offset to physical screen */ > > =C2=A0 =C2=A0 =C2=A0 =C2=A0int y_aoi_d; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0/* aoi display y offset to physical screen */ > > =C2=A0 =C2=A0 =C2=A0 =C2=A0struct fsl_diu_data *parent; > > + =C2=A0 =C2=A0 =C2=A0 char *edid_data; >=20 > edid_data should be "u8 *". "char *" is should be used only for > strings or arrays of characters. Will fix it, too. > > + =C2=A0 =C2=A0 =C2=A0 /* Still not found, use preferred mode from data= base if any */ > > + =C2=A0 =C2=A0 =C2=A0 if (!has_default_mode && info->monspecs.modedb != =3D NULL) { >=20 > No need for the "!=3D NULL" Ok, I will simplify this. Thanks, Anatolij From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Subject: Re: [PATCH 5/5] fsl-diu-fb: Support setting display mode using EDID Date: Fri, 30 Apr 2010 09:43:43 +0200 Message-ID: <20100430094343.2a504b2a@wker> References: <1272584978-19063-1-git-send-email-agust@denx.de> <1272584978-19063-6-git-send-email-agust@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org To: Timur Tabi Cc: linux-fbdev@vger.kernel.org, wd@denx.de, dzu@denx.de, devicetree-discuss@lists.ozlabs.org, linuxppc-dev@ozlabs.org, yorksun@freescale.com List-Id: devicetree@vger.kernel.org T24gVGh1LCAyOSBBcHIgMjAxMCAyMDo0NDoxMiAtMDUwMApUaW11ciBUYWJpIDx0aW11ci50YWJp QGdtYWlsLmNvbT4gd3JvdGU6Cgo+IE9uIFRodSwgQXByIDI5LCAyMDEwIGF0IDY6NDkgUE0sIEFu YXRvbGlqIEd1c3RzY2hpbiA8YWd1c3RAZGVueC5kZT4gd3JvdGU6Cj4gCj4gPiArT3B0aW9uYWwg cHJvcGVydGllczoKPiA+ICstIEVESUQgOiB2ZXJiYXRpbSBFRElEIGRhdGEgYmxvY2sgZGVzY3Jp YmluZyBhdHRhY2hlZCBkaXNwbGF5Lgo+ID4gKyDCoERhdGEgZnJvbSB0aGUgZGV0YWlsZWQgdGlt aW5nIGRlc2NyaXB0b3Igd2lsbCBiZSB1c2VkIHRvCj4gPiArIMKgcHJvZ3JhbSB0aGUgZGlzcGxh eSBjb250cm9sbGVyLgo+IAo+IFRoZSBwcm9wZXJ0eSBuYW1lIHNob3VsZCBiZSBsb3dlci1jYXNl LgoKV2lsbCBjaGFuZ2UgdG8gbG93ZXItY2FzZS4KCj4gPiDCoC8qCj4gPiDCoCogVGhlc2UgcGFy YW1ldGVycyBnaXZlIGRlZmF1bHQgcGFyYW1ldGVycwo+ID4gQEAgLTIxNyw2ICsyMTgsNyBAQCBz dHJ1Y3QgbWZiX2luZm8gewo+ID4gwqAgwqAgwqAgwqBpbnQgeF9hb2lfZDsgwqAgwqAgwqAgwqAg wqAgwqAvKiBhb2kgZGlzcGxheSB4IG9mZnNldCB0byBwaHlzaWNhbCBzY3JlZW4gKi8KPiA+IMKg IMKgIMKgIMKgaW50IHlfYW9pX2Q7IMKgIMKgIMKgIMKgIMKgIMKgLyogYW9pIGRpc3BsYXkgeSBv ZmZzZXQgdG8gcGh5c2ljYWwgc2NyZWVuICovCj4gPiDCoCDCoCDCoCDCoHN0cnVjdCBmc2xfZGl1 X2RhdGEgKnBhcmVudDsKPiA+ICsgwqAgwqAgwqAgY2hhciAqZWRpZF9kYXRhOwo+IAo+IGVkaWRf ZGF0YSBzaG91bGQgYmUgInU4ICoiLiAgImNoYXIgKiIgaXMgc2hvdWxkIGJlIHVzZWQgb25seSBm b3IKPiBzdHJpbmdzIG9yIGFycmF5cyBvZiBjaGFyYWN0ZXJzLgoKV2lsbCBmaXggaXQsIHRvby4K Cj4gPiArIMKgIMKgIMKgIC8qIFN0aWxsIG5vdCBmb3VuZCwgdXNlIHByZWZlcnJlZCBtb2RlIGZy b20gZGF0YWJhc2UgaWYgYW55ICovCj4gPiArIMKgIMKgIMKgIGlmICghaGFzX2RlZmF1bHRfbW9k ZSAmJiBpbmZvLT5tb25zcGVjcy5tb2RlZGIgIT0gTlVMTCkgewo+IAo+IE5vIG5lZWQgZm9yIHRo ZSAiIT0gTlVMTCIKCk9rLCBJIHdpbGwgc2ltcGxpZnkgdGhpcy4KClRoYW5rcywKQW5hdG9saWoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMt ZGV2IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xp c3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMtZGV2