From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, "lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 4/4] ASoC: tlv320dac33: Support for turning off the codec in BIAS_STANDBY
Date: Fri, 30 Apr 2010 12:42:27 +0100 [thread overview]
Message-ID: <20100430114227.GF28241@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <201004301355.25797.peter.ujfalusi@nokia.com>
On Fri, Apr 30, 2010 at 01:55:25PM +0300, Peter Ujfalusi wrote:
> I need to keep the dac33_pcm_prepare level of configuration for cases, when the
> codec is in ON and a playback is starting (and if the codec is not ON, than
> respond it for later, when it is switch on), right?
> I _need_ to do the things, which is done in the dac33_prepare_chip function
> every time, when a stream is starting :(
Yes, absolutely - and if we add a post-DAPM prepare callback then you
can just do that there without worrying about power in the driver.
> I do agree, that it is not really nice to have playback related thing in the
> dac33_set_bias_level, but so far I think that is the only way to avoid
> additional hassle (which means more places to have error, problems).
Like I say, I think the addition of a post-DAPM callback on prepare
ought to do the job just as well.
next prev parent reply other threads:[~2010-04-30 11:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 7:31 [PATCH 0/4] ASoC: tlv320dac33: Support for turning codec off Peter Ujfalusi
2010-04-30 7:31 ` [PATCH 1/4] ASoC: tlv320dac33: Optimize power up, and restore Peter Ujfalusi
2010-04-30 7:37 ` Peter Ujfalusi
2010-04-30 7:31 ` [PATCH 2/4] ASoC: tlv320dac33: Revised module loading, and DAC33 ID read Peter Ujfalusi
2010-04-30 7:31 ` [PATCH 3/4] ASoC: tlv320dac33: Manage a pointer for snd_pcm_substream in private structure Peter Ujfalusi
2010-04-30 7:31 ` [PATCH 4/4] ASoC: tlv320dac33: Support for turning off the codec in BIAS_STANDBY Peter Ujfalusi
2010-04-30 8:41 ` Mark Brown
2010-04-30 9:45 ` Peter Ujfalusi
2010-04-30 9:56 ` Mark Brown
2010-04-30 10:10 ` Peter Ujfalusi
2010-04-30 10:23 ` [PATCH 4/4] ASoC: tlv320dac33: Support for?turning " Mark Brown
2010-04-30 10:55 ` [PATCH 4/4] ASoC: tlv320dac33: Support for turning " Peter Ujfalusi
2010-04-30 11:42 ` Mark Brown [this message]
2010-04-30 11:42 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100430114227.GF28241@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.