All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Valdis.Kletnieks@vt.edu
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, laijs@cn.fujitsu.com,
	dipankar@in.ibm.com, akpm@linux-foundation.org,
	josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com,
	tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
	dhowells@redhat.com, eric.dumazet@gmail.com
Subject: Re: [PATCH tip/core/urgent] fix several lockdep splats, allow multiple splats
Date: Fri, 30 Apr 2010 11:02:47 -0700	[thread overview]
Message-ID: <20100430180247.GA2482@linux.vnet.ibm.com> (raw)
In-Reply-To: <10035.1272644205@localhost>

On Fri, Apr 30, 2010 at 12:16:45PM -0400, Valdis.Kletnieks@vt.edu wrote:
> On Fri, 30 Apr 2010 11:33:34 EDT, Mathieu Desnoyers said:
> 
> > I recommend creating a kernel command line parameter that would tweak
> > the number of messages printed by lockdep. The default would indeed by 1
> > message, but people in a debugging marathon can specify a larger value
> > so they won't have to reboot between each individual lockdep error.
> 
> Yeah, that would rock for development kernels - playing whack-a-mole with
> a half-dozen new lockdep whinges can easily stretch out for quite some time.

The RCU-lockdep splats are a bit different in nature than the
deadlock-related splats that lockdep normally prints.  The RCU-lockdep
splats are transient in nature, and it is easy to apply WARN_ON_ONCE().
In contrast, if you permit multiple deadlock-related lockdep splats,
you tend to get lots of warnings about the same deadlock cycle.

So how about an additional kernel configuration variable, default
disabled, perhaps named CONFIG_PROVE_RCU_MULTIPLE, that allows a
single boot to see multiple messages?  Unlike the dyntick-idle
WARN_ON()s that generated multi-gigabyte console logs in a great
hurry, I haven't yet seen excessive quantities of RCU-lockdep splats,
so I don't see the need for an integer limit.

Thoughts?

							Thanx, Paul

  reply	other threads:[~2010-04-30 18:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 20:01 [PATCH tip/core/urgent] fix several lockdep splats, allow multiple splats Paul E. McKenney
2010-04-21 20:02 ` [PATCH tip/core/urgent 1/5] rcu: Fix RCU lockdep splat in set_task_cpu on fork path Paul E. McKenney
2010-04-30 10:51   ` [tip:core/urgent] " tip-bot for Peter Zijlstra
2010-04-21 20:02 ` [PATCH tip/core/urgent 2/5] rcu: fix RCU lockdep splat on freezer_fork path Paul E. McKenney
2010-04-30 10:51   ` [tip:core/urgent] rcu: Fix " tip-bot for Paul E. McKenney
2010-04-21 20:02 ` [PATCH tip/core/urgent 3/5] rcu: leave lockdep enabled after RCU lockdep splat Paul E. McKenney
2010-04-21 20:02 ` [PATCH tip/core/urgent 4/5] NFSv4: Fix the locking in nfs_inode_reclaim_delegation() Paul E. McKenney
2010-04-21 20:02 ` [PATCH tip/core/urgent 5/5] NFS: Fix RCU issues in the NFSv4 delegation code Paul E. McKenney
2010-04-30 10:07 ` [PATCH tip/core/urgent] fix several lockdep splats, allow multiple splats Ingo Molnar
2010-04-30 15:33   ` Mathieu Desnoyers
2010-04-30 16:16     ` Valdis.Kletnieks
2010-04-30 18:02       ` Paul E. McKenney [this message]
2010-04-30 18:12         ` Mathieu Desnoyers
2010-04-30 18:32           ` Paul E. McKenney
2010-04-30 19:09             ` Mathieu Desnoyers
2010-04-30 23:47   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100430180247.GA2482@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=dvhltc@us.ibm.com \
    --cc=eric.dumazet@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=niv@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.