From: Christoph Hellwig <hch@infradead.org>
To: "Amit K. Arora" <aarora@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nikanth Karthikesan <knikanth@suse.de>,
coly.li@suse.de, Nick Piggin <npiggin@suse.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger@sun.com>,
linux-ext4@vger.kernel.org,
Eelis <opensuse.org@contacts.eelis.net>,
Amit Arora <aarora@in.ibm.com>
Subject: Re: [PATCH] Prevent creation of files larger than RLIMIT_FSIZE using fallocate
Date: Sat, 1 May 2010 06:18:46 -0400 [thread overview]
Message-ID: <20100501101846.GA3769@infradead.org> (raw)
In-Reply-To: <20100501070426.GA9562@amitarora.in.ibm.com>
On Sat, May 01, 2010 at 12:34:26PM +0530, Amit K. Arora wrote:
> Agreed. How about doing this check in the filesystem specific fallocate
> inode routines instead ? For example, in ext4 we could do :
That looks okay - in fact XFS should already have this check because
it re-uses the setattr implementation to set the size.
Can you submit an xfstests testcase to verify this behaviour on all
filesystems?
next prev parent reply other threads:[~2010-05-01 10:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 13:24 [PATCH] Prevent creation of files larger than RLIMIT_FSIZE using fallocate Nikanth Karthikesan
2010-04-28 16:15 ` Coly Li
[not found] ` <201004291014.07194.knikanth@suse.de>
[not found] ` <4BD9239D.6060907@suse.de>
2010-04-29 9:23 ` Andreas Dilger
2010-04-30 21:33 ` Andrew Morton
2010-04-30 21:40 ` Andreas Dilger
2010-05-01 7:04 ` Amit K. Arora
2010-05-01 10:18 ` Christoph Hellwig [this message]
2010-05-03 7:01 ` Amit K. Arora
2010-05-03 8:31 ` [PATCH] New testcase to check if fallocate respects RLIMIT_FSIZE or not Amit K. Arora
2010-05-03 8:31 ` Amit K. Arora
2010-05-04 20:44 ` Eric Sandeen
2010-05-04 20:44 ` Eric Sandeen
2010-05-05 7:55 ` [PATCH v2] " Amit K. Arora
2010-05-05 7:55 ` Amit K. Arora
2010-05-05 15:50 ` Eric Sandeen
2010-05-05 15:50 ` Eric Sandeen
2010-05-03 4:23 ` [PATCH] Prevent creation of files larger than RLIMIT_FSIZE using fallocate Nikanth Karthikesan
2010-05-03 6:59 ` Amit K. Arora
2010-05-03 7:49 ` Nikanth Karthikesan
2010-05-04 5:44 ` [PATCH] btrfs: " Nikanth Karthikesan
2010-05-04 5:45 ` [PATCH] ext4: " Nikanth Karthikesan
2010-05-04 6:28 ` Amit K. Arora
2010-05-21 1:11 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100501101846.GA3769@infradead.org \
--to=hch@infradead.org \
--cc=aarora@in.ibm.com \
--cc=aarora@linux.vnet.ibm.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=coly.li@suse.de \
--cc=knikanth@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=opensuse.org@contacts.eelis.net \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.