All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: [PATCH 1/3] powerpc/83xx/mcu: Add OF match table
Date: Sun, 2 May 2010 21:00:39 +0400	[thread overview]
Message-ID: <20100502170039.GA14036@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20100502165912.GA11300-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>

of_modalias_node() matches on the first (most specific) entries,
which isn't quite practical but it was discussed that this won't
change.

The bindings specifies verbose information for the devices, but
it doesn't fit in the I2C ID's 20 characters limit. The limit won't
change, and the bindings won't change either as they're correct.

So we have to put an explicit OF matching table for the
MPC8349E-mITX-compatible MCUs.

(Previously this was in the OF exception table, see commit
4c3ed7d61bd474380e0d3e1eb0da164942f7c84e.)

Signed-off-by: Anton Vorontsov <avorontsov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
---
 arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
index 59b0ed1..70798ac 100644
--- a/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
+++ b/arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c
@@ -160,10 +160,16 @@ static const struct i2c_device_id mcu_ids[] = {
 };
 MODULE_DEVICE_TABLE(i2c, mcu_ids);
 
+static struct of_device_id mcu_of_match_table[] __devinitdata = {
+	{ .compatible = "fsl,mcu-mpc8349emitx", },
+	{ },
+};
+
 static struct i2c_driver mcu_driver = {
 	.driver = {
 		.name = "mcu-mpc8349emitx",
 		.owner = THIS_MODULE,
+		.of_match_table = mcu_of_match_table,
 	},
 	.probe = mcu_probe,
 	.remove	= __devexit_p(mcu_remove),
-- 
1.7.0.5

  parent reply	other threads:[~2010-05-02 17:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201004272111.o3RLBw1f020037@imap1.linux-foundation.org>
     [not found] ` <1272428830.24542.72.camel@pasglop>
     [not found]   ` <20100430174240.GA29769@oksana.dev.rtsoft.ru>
     [not found]     ` <s2ifa686aa41004301043uca9bfbafz6db2402bfa233de4@mail.gmail.com>
     [not found]       ` <20100430174609.GA31455@oksana.dev.rtsoft.ru>
     [not found]         ` <n2yfa686aa41004302350i32d385e7gc00b49f39de417cb@mail.gmail.com>
     [not found]           ` <n2yfa686aa41004302350i32d385e7gc00b49f39de417cb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-02 16:59             ` [patch 1/6] gpiolib: introduce chip addition/removal notifier Anton Vorontsov
     [not found]               ` <20100502165912.GA11300-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2010-05-02 17:00                 ` Anton Vorontsov [this message]
2010-05-02 17:00                 ` [PATCH 2/3] serial/ucc_uart: Use .dev.of_node instead of .node in struct of_device Anton Vorontsov
2010-05-02 17:00                 ` [PATCH 3/3] USB: FHCI: " Anton Vorontsov
2010-05-02 19:34                 ` [patch 1/6] gpiolib: introduce chip addition/removal notifier Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100502170039.GA14036@oksana.dev.rtsoft.ru \
    --to=avorontsov-igf4poytycdqt0dzr+alfa@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.