All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: eric.dumazet@gmail.com, ebiederm@xmission.com,
	johannes@sipsolutions.net, therbert@google.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: show stopped status in sysfs
Date: Mon, 03 May 2010 15:05:24 -0700 (PDT)	[thread overview]
Message-ID: <20100503.150524.250828270.davem@davemloft.net> (raw)
In-Reply-To: <20100503212423.GA15998@redhat.com>

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Tue, 4 May 2010 00:24:25 +0300

> @@ -303,6 +313,7 @@ static struct device_attribute net_class_attributes[] = {
>  	__ATTR(address, S_IRUGO, show_address, NULL),
>  	__ATTR(broadcast, S_IRUGO, show_broadcast, NULL),
>  	__ATTR(carrier, S_IRUGO, show_carrier, NULL),
> +	__ATTR(carrier, S_IRUGO, show_stopped, NULL),

Besides the fact that you have to publish this as a per-queue attribute,
you're also erroneously naming it 'carrier' here.

  parent reply	other threads:[~2010-05-03 22:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-03 21:24 [PATCH] net: show stopped status in sysfs Michael S. Tsirkin
2010-05-03 21:44 ` Ben Hutchings
2010-05-03 22:04   ` David Miller
2010-05-03 22:05 ` David Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-05-03 21:24 Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100503.150524.250828270.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=eric.dumazet@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.