Re: [PATCH v2 3/4] omap: mailbox: fix reverse likeliness

[Tony Lindgren <tony@atomide.com>]

* Ohad Ben-Cohen <ohad@wizery.com> [100502 08:40]:
> Fix reverse likeliness
> 
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> ---
> If you want, you can also reach me at < ohadb at ti dot com >.
> 
>  arch/arm/plat-omap/mailbox.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c
> index 5140efc..5309213 100644
> --- a/arch/arm/plat-omap/mailbox.c
> +++ b/arch/arm/plat-omap/mailbox.c
> @@ -290,7 +290,7 @@ static int omap_mbox_startup(struct omap_mbox *mbox)
>   fail_alloc_txq:
>  	free_irq(mbox->irq, mbox);
>   fail_request_irq:
> -	if (unlikely(mbox->ops->shutdown))
> +	if (likely(mbox->ops->shutdown))
>  		mbox->ops->shutdown(mbox);
>  
>  	return ret;
> @@ -303,7 +303,7 @@ static void omap_mbox_fini(struct omap_mbox *mbox)
>  
>  	free_irq(mbox->irq, mbox);
>  
> -	if (unlikely(mbox->ops->shutdown)) {
> +	if (likely(mbox->ops->shutdown)) {
>  		spin_lock(&mboxes_lock);
>  		if (mbox_configured > 0)
>  			mbox_configured--;

Does this code path need to be optimized? :)

How about just get rid of the (un)likely here?

Regards,

Tony