From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933542Ab0EDQGG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 4 May 2010 12:06:06 -0400
Received: from kroah.org ([198.145.64.141]:41196 "EHLO coco.kroah.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933397Ab0EDQGA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 4 May 2010 12:06:00 -0400
Date: Tue, 4 May 2010 08:51:12 -0700
From: Greg KH <greg@kroah.com>
To: Alan Cox <alan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Staging: RAR support - bring ready to move from staging
Message-ID: <20100504155112.GA26143@kroah.com>
References: <20100504105032.3de58e68@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20100504105032.3de58e68@linux.intel.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 04, 2010 at 10:50:32AM +0100, Alan Cox wrote:
> 
> rar: perform a clean up pass
> 
> - Move to a registration model where each RAR is claimed/unclaimed
> - Use that to fix the client stuff (one client per RAR so no need to queue stuff)
> - Support unregister so drivers can rmmod themselves safely
> - Fix locking hang on calling rar lock from rar callback
> - Clean up
> - Kerneldoc

I get the following build errors with this patch:
	  CC [M]  drivers/staging/memrar/memrar_handler.o
	drivers/staging/memrar/memrar_handler.c: In function ‘memrar_init’:
	drivers/staging/memrar/memrar_handler.c:910: warning: passing argument 1 of ‘register_rar’ makes integer from pointer without a cast
	drivers/staging/memrar/../rar_register/rar_register.h:37: note: expected ‘int’ but argument is of type ‘int (*)(void *)’
	drivers/staging/memrar/memrar_handler.c:910: error: too few arguments to function ‘register_rar’
	make[2]: *** [drivers/staging/memrar/memrar_handler.o] Error 1
	make[1]: *** [drivers/staging/memrar] Error 2
	make: *** [_module_drivers/staging] Error 2

Should I have applied your other patch first?

thanks,

greg k-h