From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Peter Lieven <pl@dlh.net>, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion
Date: Tue, 4 May 2010 19:07:06 +0200 [thread overview]
Message-ID: <20100504170706.GA21339@lst.de> (raw)
In-Reply-To: <4BE028BF.1000603@redhat.com>
On Tue, May 04, 2010 at 04:01:35PM +0200, Kevin Wolf wrote:
> Great, I'm going to submit it as a proper patch then.
>
> Christoph, by now I'm pretty sure it's right, but can you have another
> look if this is correct, anyway?
It looks correct to me - we really shouldn't update the the fields
until bdrv_aio_cancel has returned. In fact we cannot cancel a request
more often than we can, so there's a fairly high chance it will
complete.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2010-05-04 17:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 21:26 Qemu-KVM 0.12.3 and Multipath -> Assertion Peter Lieven
2010-05-03 21:26 ` [Qemu-devel] " Peter Lieven
2010-05-04 5:38 ` André Weidemann
2010-05-04 5:38 ` [Qemu-devel] " André Weidemann
2010-05-04 8:35 ` [Qemu-devel] " Kevin Wolf
2010-05-04 8:35 ` Kevin Wolf
2010-05-04 11:38 ` Peter Lieven
2010-05-04 11:38 ` Peter Lieven
2010-05-04 12:20 ` Kevin Wolf
2010-05-04 12:20 ` Kevin Wolf
2010-05-04 13:42 ` Peter Lieven
2010-05-04 13:42 ` Peter Lieven
2010-05-04 14:01 ` Kevin Wolf
2010-05-04 14:01 ` Kevin Wolf
2010-05-04 17:07 ` Christoph Hellwig [this message]
2010-05-18 11:13 ` Peter Lieven
2010-05-18 12:14 ` Kevin Wolf
2010-05-18 12:14 ` Kevin Wolf
2010-05-12 14:01 ` qemu-kvm hangs if multipath device is queing (was: Re: [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion) Peter Lieven
2010-05-14 9:26 ` qemu-kvm hangs if multipath device is queing Kevin Wolf
2010-05-14 9:26 ` [Qemu-devel] " Kevin Wolf
2010-05-18 11:10 ` Peter Lieven
2010-05-18 11:10 ` [Qemu-devel] " Peter Lieven
2010-05-18 13:22 ` Kevin Wolf
2010-05-18 13:22 ` [Qemu-devel] " Kevin Wolf
2010-05-19 7:29 ` Christoph Hellwig
2010-05-19 7:29 ` [Qemu-devel] " Christoph Hellwig
2010-05-19 7:48 ` Kevin Wolf
2010-05-19 7:48 ` [Qemu-devel] " Kevin Wolf
2010-05-19 8:18 ` Peter Lieven
2010-05-19 8:18 ` [Qemu-devel] " Peter Lieven
2010-05-23 10:30 ` Peter Lieven
2010-05-08 9:53 ` [Qemu-devel] Qemu-KVM 0.12.3 and Multipath -> Assertion André Weidemann
2010-05-08 9:53 ` André Weidemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504170706.GA21339@lst.de \
--to=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=pl@dlh.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.