From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: Re: [PATCH][cr-test] eclone-2 bug fix Date: Tue, 4 May 2010 10:30:51 -0700 Message-ID: <20100504173051.GA11116@us.ibm.com> References: <20100504020919.GB5098@us.ibm.com> <20100504133328.GA10214@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20100504133328.GA10214-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: Containers List-Id: containers.vger.kernel.org Serge E. Hallyn [serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org] wrote: | Note that if pid > 0 you don't print out an error msg. I pushed a | trivial patch on top of this one to do so. Pls let me know if I | misunderstood and that wasn't right. Well, if the child was created (i.e pid > 0) do_child() prints a "FAIL" message and the test exits with 1. But the message does not hurt, although for consistency we should mark it "FAIL" rather than "ERROR". Thanks, Sukadev