From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH][cr-test] eclone-2 bug fix Date: Tue, 4 May 2010 14:39:34 -0500 Message-ID: <20100504193934.GA4781@us.ibm.com> References: <20100504020919.GB5098@us.ibm.com> <20100504133328.GA10214@us.ibm.com> <20100504173051.GA11116@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20100504173051.GA11116-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Sukadev Bhattiprolu Cc: Containers List-Id: containers.vger.kernel.org Quoting Sukadev Bhattiprolu (sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org): > Serge E. Hallyn [serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org] wrote: > | Note that if pid > 0 you don't print out an error msg. I pushed a > | trivial patch on top of this one to do so. Pls let me know if I > | misunderstood and that wasn't right. > > Well, if the child was created (i.e pid > 0) do_child() prints a "FAIL" > message and the test exits with 1. But the message does not hurt, although Thinking in terms of future ltp integration, I'm not sure whether the child doing a TFAIL will result in parent test reporting failure on exit or not, so I prefer the parent report failure when possible. > for consistency we should mark it "FAIL" rather than "ERROR". Uh, I guess I was following you example :) I've changed both and pushed. thanks, -serge