From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Allow the i.mx25 3DStack target to compile.
Date: Tue, 4 May 2010 23:04:05 +0300 [thread overview]
Message-ID: <20100504200405.GA2388@tarshish> (raw)
In-Reply-To: <1273000248-10142-1-git-send-email-jcd@tribudubois.net>
Hi Jean-Christophe,
On Tue, May 04, 2010 at 09:10:48PM +0200, Jean-Christophe DUBOIS wrote:
> This is a resend because I wrongly submited this pach to
> linux-arm mailing list instead of linux-arm-kernel.
>
> The FEC driver is not compiling for 3Dstack evaluation board
> in the actual state. Fix it.
See http://patchwork.ozlabs.org/patch/41235/ for a better alternative. For
some reason this patch hasn't found its way to the mainline kernel yet. Until
it does the i.MX25 PDK platform code is broken.
> Signed-off-by: Jean-Chrsitophe DUBOIS <jcd@tribudubois.net>
> ---
> arch/arm/mach-mx25/mx25pdk.c | 9 ++++-----
This file has been renamed to mach-mx25pdk.c since 2.6.34-rc2, so your patch
does not apply.
baruch
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-mx25/mx25pdk.c b/arch/arm/mach-mx25/mx25pdk.c
> index 6f06089..cbf45c0 100644
> --- a/arch/arm/mach-mx25/mx25pdk.c
> +++ b/arch/arm/mach-mx25/mx25pdk.c
> @@ -22,7 +22,6 @@
> #include <linux/clk.h>
> #include <linux/irq.h>
> #include <linux/gpio.h>
> -#include <linux/fec.h>
> #include <linux/platform_device.h>
>
> #include <mach/hardware.h>
> @@ -56,8 +55,9 @@ static struct pad_desc mx25pdk_pads[] = {
> MX25_PAD_D12__GPIO_4_8, /* FEC_RESET_B, GPIO 104 */
> };
>
> -static struct fec_platform_data mx25_fec_pdata = {
> - .phy = PHY_INTERFACE_MODE_RMII,
> +static struct platform_device *platform_devices[] __initdata = {
> + &mxc_usbh2,
> + &mx25_fec_device,
> };
>
> #define FEC_ENABLE_GPIO 35
> @@ -83,10 +83,9 @@ static void __init mx25pdk_init(void)
> ARRAY_SIZE(mx25pdk_pads));
>
> mxc_register_device(&mxc_uart_device0, &uart_pdata);
> - mxc_register_device(&mxc_usbh2, NULL);
>
> mx25pdk_fec_reset();
> - mxc_register_device(&mx25_fec_device, &mx25_fec_pdata);
> + platform_add_devices(platform_devices, ARRAY_SIZE(platform_devices));
> }
>
> static void __init mx25pdk_timer_init(void)
> --
> 1.7.0.4
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2010-05-04 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 19:10 [PATCH] Allow the i.mx25 3DStack target to compile Jean-Christophe DUBOIS
2010-05-04 20:04 ` Baruch Siach [this message]
2010-05-04 20:23 ` Jean-Christophe Dubois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504200405.GA2388@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.