All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Alan Hourihane <alanh@fairlite.co.uk>
Cc: git@vger.kernel.org
Subject: Re: new platform & S_IFGITLINK problem
Date: Tue, 4 May 2010 21:29:08 -0500	[thread overview]
Message-ID: <20100505022907.GA17743@progeny.tock> (raw)
In-Reply-To: <1272756555.13488.1314.camel@jetpack.demon.co.uk>

Hi,

Alan Hourihane wrote:

> Additionally, attached is a patch that I currently need to apply in
> order to compile git successfully on the FreeMiNT platform (which is
> m68k based).
> 
> Comments appreciated.

While wiser people discuss the hard part, here are some tiny nitpicks. :)

> --- /dev/null	2008-12-07 20:01:52.000000000 +0000
> +++ compat/mint.h	2008-12-23 11:52:10.000000000 +0000
> @@ -0,0 +1,2 @@
> +#define SA_RESTART 0
> +#define ss_family sa_family

Does MiNT restart interrupted system calls by default?  Are most
operations generally not interruptible anyway?

> --- Makefile	2009-01-29 12:12:01.000000000 +0000
> +++ Makefile	2009-01-29 12:13:39.000000000 +0000
> @@ -1618,7 +1613,7 @@
>  
>  git-imap-send$X: imap-send.o $(GITLIBS)
>  	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
> -		$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)
> +		$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)

NEEDS_CRYPTO_WITH_SSL = YesPlease

[...]
>  git-http-fetch$X: revision.o http.o http-walker.o http-fetch.o $(GITLIBS)
>  	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
> -		$(LIBS) $(CURL_LIBCURL)
> +		$(LIBS) $(CURL_LIBCURL) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)
[...]

CURL_LIBCURL = -lcurl $(OPENSSL_LIBSSL)

Hope that helps,
Jonathan

  parent reply	other threads:[~2010-05-05  2:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-01 23:29 new platform & S_IFGITLINK problem Alan Hourihane
2010-05-02  2:33 ` Junio C Hamano
2010-05-02  9:39   ` Alan Hourihane
2010-05-04  3:39   ` Linus Torvalds
2010-05-04  3:52     ` Linus Torvalds
2010-05-04  6:13       ` Andreas Ericsson
2010-05-04 14:34         ` Linus Torvalds
2010-05-04 15:29       ` Junio C Hamano
2010-05-04  7:21     ` Alan Hourihane
2010-07-22 16:23   ` Alan Hourihane
2010-07-25 17:29     ` Junio C Hamano
2010-07-25 18:00       ` Alan Hourihane
2010-08-02 16:11         ` Ævar Arnfjörð Bjarmason
2010-08-02 16:14           ` Alan Hourihane
2010-08-02 16:26             ` Ævar Arnfjörð Bjarmason
2010-05-05  2:29 ` Jonathan Nieder [this message]
2010-05-05  8:36   ` Alan Hourihane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100505022907.GA17743@progeny.tock \
    --to=jrnieder@gmail.com \
    --cc=alanh@fairlite.co.uk \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.