From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "Valentin Eduardo (Nokia-D/Helsinki)"
<eduardo.valentin@nokia.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Liam@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: omap: Add basic audio support for Nokia RX-51/N900
Date: Wed, 5 May 2010 09:48:29 +0300 [thread overview]
Message-ID: <20100505094829.ffec7939.jhnikula@gmail.com> (raw)
In-Reply-To: <201005050930.22712.peter.ujfalusi@nokia.com>
On Wed, 5 May 2010 09:30:22 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> Also, tlv320aic3x driver will try to set the defaults to the codec during the
> i2c probing. I'm not sure, but if the reset line is low at that point it may
> cause problems (reset line is low, and the reset sequence has not been
> followed).
> Than later in the machine driver the chip is taken out from reset, which might
> means, that the chip will be in reset state, so the initial configuration done
> by the codec driver might be lost.
>
> I think it would be better to handle the reset GPIO within the codec driver at
> the end for proper operation.
>
> What do you think?
>
Thanks! Definitely reset handling is better to move to codec driver.
Especially important if starting to manage digital voltages there. I'll
cook up updated versions.
--
Jarkko
next prev parent reply other threads:[~2010-05-05 6:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 5:31 [PATCH] ASoC: omap: Add basic audio support for Nokia RX-51/N900 Jarkko Nikula
2010-05-05 6:30 ` Peter Ujfalusi
2010-05-05 6:48 ` Jarkko Nikula [this message]
2010-05-05 7:02 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505094829.ffec7939.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=Liam@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eduardo.valentin@nokia.com \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.