From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCHv2] ASoC: tlv320aic3x: Add platform data and reset gpio handling
Date: Wed, 5 May 2010 12:28:03 +0100 [thread overview]
Message-ID: <20100505112803.GE5754@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1273053723-6304-1-git-send-email-jhnikula@gmail.com>
On Wed, May 05, 2010 at 01:02:03PM +0300, Jarkko Nikula wrote:
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
but...
> + if (aic3x->gpio_reset >= 0) {
> + gpio_set_value(aic3x->gpio_reset, 0);
> + gpio_free(aic3x->gpio_reset);
> + }
There is gpio_is_valid().
next prev parent reply other threads:[~2010-05-05 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 10:02 [PATCHv2] ASoC: tlv320aic3x: Add platform data and reset gpio handling Jarkko Nikula
2010-05-05 11:28 ` Mark Brown [this message]
2010-05-06 8:09 ` Peter Ujfalusi
2010-05-06 8:17 ` Liam Girdwood
2010-05-06 9:08 ` Peter Ujfalusi
2010-05-06 9:52 ` Mark Brown
2010-05-06 11:23 ` Peter Ujfalusi
2010-05-06 10:18 ` Jarkko Nikula
2010-05-06 14:05 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505112803.GE5754@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jhnikula@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.