All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jhnikula@gmail.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: "Candelaria Villarreal, Jorge" <jorge.candelaria@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/2] ARM: McBSP: Fix request for irq in OMAP4
Date: Wed, 5 May 2010 13:39:03 +0300	[thread overview]
Message-ID: <20100505133903.cde41896.jhnikula@gmail.com> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E94026F8C6E56@dbde02.ent.ti.com>

On Wed, 5 May 2010 08:32:13 +0530
"G, Manjunath Kondaiah" <manjugk@ti.com> wrote:

> > -		init_completion(&mcbsp->rx_irq_completion);
> > -		err = request_irq(mcbsp->rx_irq, 
> > omap_mcbsp_rx_irq_handler,
> > +		if (!cpu_is_omap44xx) {
> > +			init_completion(&mcbsp->rx_irq_completion);
> > +			err = request_irq(mcbsp->rx_irq,
> > +					omap_mcbsp_rx_irq_handler,
> >  					0, "McBSP", (void *)mcbsp);
> 
> How about using request_threaded_irq?
> Refer to: http://lwn.net/Articles/302043/
> 
Threaded irq conversion would be better to handle as a separate patch
as it does different thing than this patch.

-- 
Jarkko

  reply	other threads:[~2010-05-05 10:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04 23:37 [PATCH 0/0] McBSP changes for OMAP4 platform Jorge Eduardo Candelaria
2010-05-04 23:37 ` [PATCH 1/2] ARM: McBSP: Fix request for irq in OMAP4 Jorge Eduardo Candelaria
2010-05-04 23:37   ` [PATCH 2/2] ARM: OMAP4: Add support for omap4 in McBSP driver Jorge Eduardo Candelaria
2010-05-05  3:02   ` [PATCH 1/2] ARM: McBSP: Fix request for irq in OMAP4 G, Manjunath Kondaiah
2010-05-05 10:39     ` Jarkko Nikula [this message]
2010-05-06  0:58       ` Candelaria Villarreal, Jorge
2010-05-05 10:29   ` Jarkko Nikula
2010-05-05 11:11     ` Shilimkar, Santosh
2010-05-05 21:16   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100505133903.cde41896.jhnikula@gmail.com \
    --to=jhnikula@gmail.com \
    --cc=jorge.candelaria@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=manjugk@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.