From: Thomas Rast <trast@student.ethz.ch>
To: Leif Arne Storset <lstorset@opera.com>
Cc: <git@vger.kernel.org>, <gitster@pobox.com>
Subject: Re: [PATCH] Documentation/config.txt: Move GIT_NOTES_REWRITE_REF to notes.rewriteRef
Date: Wed, 5 May 2010 16:00:03 +0200 [thread overview]
Message-ID: <201005051600.03446.trast@student.ethz.ch> (raw)
In-Reply-To: <1273066516-24469-1-git-send-email-lstorset@opera.com>
Leif Arne Storset wrote:
> Was notes.rewrite. The environment variable refers to globs and refs, which are only mentioned by notes.rewriteRef; notes.rewrite is boolean.
>
> Signed-off-by: Leif Arne Storset <lstorset@opera.com>
> ---
> This should be a trivial fix.
ACK and thanks for spotting this. Putting it in the wrong place was
my fault.
I found the commit message confusing, though (my first thought was "we
have a notes.rewrite configuration variable?"), and you also have a
way too long line there. How about
Documentation/config.txt: GIT_NOTES_REWRITE_REF overrides notes.rewriteRef
The documentation erroneously mentions the GIT_NOTES_REWRITE_REF
override in the description of notes.rewrite.<command>. Move it
under notes.rewriteRef where it belongs.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-05-05 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 13:35 [PATCH] Documentation/config.txt: Move GIT_NOTES_REWRITE_REF to notes.rewriteRef Leif Arne Storset
2010-05-05 14:00 ` Thomas Rast [this message]
2010-05-05 14:15 ` Leif Arne Storset
2010-05-05 14:16 ` [PATCH] Documentation/config.txt: GIT_NOTES_REWRITE_REF overrides notes.rewriteRef Leif Arne Storset
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005051600.03446.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lstorset@opera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.