From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: Old DSS code broken as module (was "RE: [PATCH 11/11] omap2/3/4: Disable CONFIG_FB_OMAP in omap3_defconfig") Date: Wed, 5 May 2010 10:43:35 -0700 Message-ID: <20100505174335.GZ29604@atomide.com> References: <20100430202603.25812.41834.stgit@baageli.muru.com> <20100430203411.25812.30019.stgit@baageli.muru.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:57191 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752889Ab0EERnl (ORCPT ); Wed, 5 May 2010 13:43:41 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Aguirre, Sergio" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" , Tomi Valkeinen * Aguirre, Sergio [100505 10:27]: > Tony, > > > -----Original Message----- > > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- > > owner@vger.kernel.org] On Behalf Of Tony Lindgren > > Sent: Friday, April 30, 2010 3:34 PM > > To: linux-arm-kernel@lists.infradead.org > > Cc: linux-omap@vger.kernel.org > > Subject: [PATCH 11/11] omap2/3/4: Disable CONFIG_FB_OMAP in > > omap3_defconfig > > > > Looks like CONFIG_FB_OMAP prevents somehow mounting root on MMC > > at least on zoom3 for multi-omap. Disable CONFIG_FB until the > > omap FB code is fixed. > > > > This allows booting omap3_defconfig on various omaps. Tested on > > 2420-n8x0, 3430-n900, 3630-zoom3 and 4430-blaze. Note that n8x0 > > still has issues with starting user space because of TLS and > > VFP. > > (Looping Tomi) > > Unfortunately, your patch is uncovering an issue with old DSS code to > compile it as module, which I think is caused by this: > > A single omapfb.ko is attempted to be created in drivers/video/omap/ folder, > but the included source files (DSS code + lcd drivers), results in multiple > module_init entries added in a single module, and therefore giving errors of > duplicate init_module entries between omapfb_main.c and the lcd_*.c files. > > So, either you disable old DSS driver completely, or you have it as > built-in. OK thanks for pointing that out. I'll disable it so we have a booting omap3_defconfig (with the modules compiling). Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 5 May 2010 10:43:35 -0700 Subject: Old DSS code broken as module (was "RE: [PATCH 11/11] omap2/3/4: Disable CONFIG_FB_OMAP in omap3_defconfig") In-Reply-To: References: <20100430202603.25812.41834.stgit@baageli.muru.com> <20100430203411.25812.30019.stgit@baageli.muru.com> Message-ID: <20100505174335.GZ29604@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Aguirre, Sergio [100505 10:27]: > Tony, > > > -----Original Message----- > > From: linux-omap-owner at vger.kernel.org [mailto:linux-omap- > > owner at vger.kernel.org] On Behalf Of Tony Lindgren > > Sent: Friday, April 30, 2010 3:34 PM > > To: linux-arm-kernel at lists.infradead.org > > Cc: linux-omap at vger.kernel.org > > Subject: [PATCH 11/11] omap2/3/4: Disable CONFIG_FB_OMAP in > > omap3_defconfig > > > > Looks like CONFIG_FB_OMAP prevents somehow mounting root on MMC > > at least on zoom3 for multi-omap. Disable CONFIG_FB until the > > omap FB code is fixed. > > > > This allows booting omap3_defconfig on various omaps. Tested on > > 2420-n8x0, 3430-n900, 3630-zoom3 and 4430-blaze. Note that n8x0 > > still has issues with starting user space because of TLS and > > VFP. > > (Looping Tomi) > > Unfortunately, your patch is uncovering an issue with old DSS code to > compile it as module, which I think is caused by this: > > A single omapfb.ko is attempted to be created in drivers/video/omap/ folder, > but the included source files (DSS code + lcd drivers), results in multiple > module_init entries added in a single module, and therefore giving errors of > duplicate init_module entries between omapfb_main.c and the lcd_*.c files. > > So, either you disable old DSS driver completely, or you have it as > built-in. OK thanks for pointing that out. I'll disable it so we have a booting omap3_defconfig (with the modules compiling). Regards, Tony