From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: tlv320dac33: Use codec defaults for LOM/LOP and DAC power Date: Thu, 6 May 2010 11:35:27 +0100 Message-ID: <20100506103527.GD30491@rakim.wolfsonmicro.main> References: <1273136665-3340-1-git-send-email-peter.ujfalusi@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 6B41C24688 for ; Thu, 6 May 2010 12:35:28 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1273136665-3340-1-git-send-email-peter.ujfalusi@nokia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Peter Ujfalusi Cc: alsa-devel@alsa-project.org, lrg@slimlogic.co.uk List-Id: alsa-devel@alsa-project.org On Thu, May 06, 2010 at 12:04:25PM +0300, Peter Ujfalusi wrote: > Do not change the codec defaults for the following registers: > 0x40, 0x41: Line output gains, do not use amplification > 0x42: LOM/LOP Voltage hold, and selection > 0x44: LOM inversion control > > It has been found, that the values configured to these registers > can cause amplification, which can make the output of DAC33 > distorted. > > The codec reset values are considered safe in all environmnts. > > Signed-off-by: Peter Ujfalusi Acked-by: Mark Brown