From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Simon Arlott <simon@fire.lp0.eu>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH (v2)] bridge: update sysfs link names if port device names have changed
Date: Thu, 6 May 2010 12:11:07 -0700 [thread overview]
Message-ID: <20100506121107.1868ad07@nehalam> (raw)
In-Reply-To: <4BE31218.6010709@simon.arlott.org.uk>
On Thu, 06 May 2010 20:01:44 +0100
Simon Arlott <simon@fire.lp0.eu> wrote:
> +
> + case NETDEV_CHANGENAME:
> + err = br_sysfs_renameif(p);
> + if (err)
> + return NOTIFY_BAD;
> + break;
I think you want:
if (err)
return notifier_from_errno(err);
+ err = sysfs_rename_link(br->ifobj, &p->kobj,
+ p->sysfs_name, p->dev->name);
+ if (err) {
+ printk(KERN_ERR "%s: unable to rename sysfs link %s to %s (%d)",
+ br->dev->name, p->sysfs_name, p->dev->name, err);
This should not be KERN_ERR but KERN_NOTICE, and use new wrapper macros.
if (err)
netdev_notice(br->dev, "unable to rename sysfs link %s to %s".
p->sysfs_name, p->dev->name, err)
next prev parent reply other threads:[~2010-05-06 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 18:32 [PATCH] bridge: update sysfs link names if port device names have changed Simon Arlott
2010-05-06 18:53 ` Stephen Hemminger
2010-05-06 19:01 ` [PATCH (v2)] " Simon Arlott
2010-05-06 19:11 ` Stephen Hemminger [this message]
2010-05-06 19:37 ` [PATCH (v4)] " Simon Arlott
2010-05-06 19:40 ` Stephen Hemminger
2010-05-06 19:50 ` [PATCH (v4+)] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506121107.1868ad07@nehalam \
--to=shemminger@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.