All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org>
To: Henrique de Moraes Holschuh
	<hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
Cc: linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ibm-acpi-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org,
	ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH 2/2] thinkpad_acpi: Hook volume events
Date: Thu, 6 May 2010 13:47:48 +0100	[thread overview]
Message-ID: <20100506124748.GA22190@srcf.ucam.org> (raw)
In-Reply-To: <20100506030239.GB19265-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>

On Thu, May 06, 2010 at 12:02:39AM -0300, Henrique de Moraes Holschuh wrote:

> Reading that stuff ain't cheap.  Either a locked trip through the LPC bus
> for the CMOS nvram, or ACPI EC I/O (which is even worse, I fear.  That EC is
> also hooked to LPC, and there's a lot more code involved).
> 
> I really would rather not enable it on boxes where it isn't required.  And
> we know which ones are those: IBM thinkpads where the all-available-hotkeys
> mask has the bits for the volume hotkeys set.

Ok, that's easy enough to do. I'll rework and send that.

-- 
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org

------------------------------------------------------------------------------

      parent reply	other threads:[~2010-05-06 12:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-03 20:02 [PATCH 1/2] acpi: Provide interface for driver notification on method call Matthew Garrett
2010-05-03 20:03 ` [PATCH 2/2] thinkpad_acpi: Hook volume events Matthew Garrett
2010-05-05 11:30   ` Henrique de Moraes Holschuh
2010-05-05 13:20     ` Matthew Garrett
2010-05-06  3:02       ` Henrique de Moraes Holschuh
     [not found]         ` <20100506030239.GB19265-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2010-05-06 12:47           ` Matthew Garrett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100506124748.GA22190@srcf.ucam.org \
    --to=mjg59-1xo5oi07kqx4cg9nei1l7q@public.gmane.org \
    --cc=hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org \
    --cc=ibm-acpi-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org \
    --cc=ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.