From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Get rid of KVM_REQ_KICK
Date: Thu, 6 May 2010 16:56:37 -0300 [thread overview]
Message-ID: <20100506195637.GD3432@amt.cnet> (raw)
In-Reply-To: <1272896348-13514-1-git-send-email-avi@redhat.com>
On Mon, May 03, 2010 at 05:19:08PM +0300, Avi Kivity wrote:
> KVM_REQ_KICK poisons vcpu->requests by having a bit set during normal
> operation. This causes the fast path check for a clear vcpu->requests
> to fail all the time, triggering tons of atomic operations.
>
> Fix by replacing KVM_REQ_KICK with a vcpu->guest_mode atomic.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
> arch/x86/kvm/x86.c | 17 ++++++++++-------
> include/linux/kvm_host.h | 1 +
> 2 files changed, 11 insertions(+), 7 deletions(-)
Reviewed-by: Marcelo Tosatti <mtosatti@redhat.com>
prev parent reply other threads:[~2010-05-06 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 14:19 [PATCH] KVM: Get rid of KVM_REQ_KICK Avi Kivity
2010-05-04 16:31 ` Marcelo Tosatti
2010-05-04 16:42 ` Avi Kivity
2010-05-04 16:49 ` Avi Kivity
2010-05-06 19:56 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506195637.GD3432@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.