From: Jean-Francois Moine <moinejf@free.fr>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Jose Alberto Reguero <jareguero@telefonica.net>,
Hans de Goede <hdegoede@redhat.com>,
linux-media@vger.kernel.org
Subject: Re: Problem with gspca and zc3xx
Date: Thu, 6 May 2010 20:32:18 +0200 [thread overview]
Message-ID: <20100506203218.31c62786@tele> (raw)
In-Reply-To: <4BE305DD.5020106@redhat.com>
On Thu, 06 May 2010 15:09:33 -0300
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
> > I found the problem. Autogain don't work well if brightness is de
> > default value(128). if brightness is less(64) autogain work well.
> > There is a problem when setting the brightness. It is safe to
> > remove the brightness control? Patch attached.
> >
> > Jose Alberto
>
> This patch doesn't apply anymore. I'm not sure if the issue were
> fixed upstream. If not, please re-base your patch against my git tree
> and send it again.
>
> patching file drivers/media/video/gspca/zc3xx.c
> Hunk #1 succeeded at 6086 with fuzz 1 (offset 45 lines).
> Hunk #2 FAILED at 6882.
> 1 out of 2 hunks FAILED -- saving rejects to file
> drivers/media/video/gspca/zc3xx.c.rej
> >>> Patch patches/lmml_72895_problem_with_gspca_and_zc3xx.patch
> >>> doesn't apply
Jose's patch is not needed anymore. I completely removed the brightness
control as it was done: it did not work for any zc3xx webcam. The git
change is bdd13e1bf3ada06bb9ccd04f5f65f7912eff72af.
Cheers.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2010-05-06 18:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 23:15 Problem with gspca and zc3xx Jose Alberto Reguero
2010-01-10 8:37 ` Jean-Francois Moine
2010-01-10 10:31 ` Jose Alberto Reguero
2010-01-11 8:37 ` Hans de Goede
2010-01-11 9:55 ` Jean-Francois Moine
2010-01-11 14:49 ` Jose Alberto Reguero
2010-01-12 8:36 ` Jean-Francois Moine
2010-01-12 11:54 ` Hans de Goede
2010-01-12 14:57 ` Jose Alberto Reguero
2010-01-13 13:50 ` Jose Alberto Reguero
2010-01-14 16:26 ` Jose Alberto Reguero
2010-05-06 18:09 ` Mauro Carvalho Chehab
2010-05-06 18:32 ` Jean-Francois Moine [this message]
2010-01-11 22:03 ` Hans de Goede
-- strict thread matches above, loose matches on Subject: below --
2010-01-28 13:35 Fabio Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506203218.31c62786@tele \
--to=moinejf@free.fr \
--cc=hdegoede@redhat.com \
--cc=jareguero@telefonica.net \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.