From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:36693 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874Ab0EGCpN (ORCPT ); Thu, 6 May 2010 22:45:13 -0400 Date: Thu, 6 May 2010 22:35:20 -0400 From: "John W. Linville" To: "Luis R. Rodriguez" Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH] mac80211: set IEEE80211_TX_CTL_FIRST_FRAGMENT for beacons Message-ID: <20100507023519.GA7240@tuxdriver.com> References: <1273171517-6264-1-git-send-email-linville@tuxdriver.com> <20100507001319.GA6990@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20100507001319.GA6990@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, May 06, 2010 at 08:13:20PM -0400, John W. Linville wrote: > On Thu, May 06, 2010 at 03:01:25PM -0700, Luis R. Rodriguez wrote: > > On Thu, May 6, 2010 at 11:45 AM, John W. Linville > > wrote: > > > > Why though? > > Because it is correct, appropriate, and zero additional cost. And > because if you use the same tx path for beacons as you use for normal > frames and if in that path you manage the sequence number in software > you should be checking that flag before bumping the sequence number. That isn't worded too clearly... If you manage the sequence number in software then you should be checking that flag before bumping the sequence number. If you use the same tx path for beacons as is used for normal frames and you don't set that flag for beacons, then beacons will reuse the sequence number from the previous frame. Does that make sense? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.