From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: add some INTC_VECT for SH7757
Date: Fri, 07 May 2010 10:41:11 +0000 [thread overview]
Message-ID: <20100507104110.GH14009@linux-sh.org> (raw)
In-Reply-To: <4BE3DBEB.5060209@renesas.com>
On Fri, May 07, 2010 at 07:27:16PM +0900, Yoshihiro Shimoda wrote:
> Paul Mundt wrote:
> > On Fri, May 07, 2010 at 06:22:51PM +0900, Yoshihiro Shimoda wrote:
> >> And I also add the setting of mv_nr_irqs because SH7757 has irqs
> >> more than 256.
> >>
> > Since everything is using sparseirq these days, just bump up NR_IRQS to
> > 512. CPUs should not be touching the machvec under any circumstances.
> >
> May I change the NR_IRQS in arch/sh/include/asm/irq.h?
Yes.
> I thought that if this define is changed, all CPUs were affected.
> Also I thought that there was not good to add "#ifdef CONFIG_CPU_SUBTYPE_SH7757" here.
> What should I do?
These days everything uses sparseirq, and IRQ descs are allocated when
the vector map is registered, as well as dynamically for the dynamic IRQ
cases. Having a large NR_IRQS is not that much overhead since we no
longer have an entire backing irq_desc[] array that spans the entire
range.
As such, you can just change the NR_IRQS definition to 512
unconditionally without worrying too much about the overhead.
prev parent reply other threads:[~2010-05-07 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 9:22 [PATCH] sh: add some INTC_VECT for SH7757 Yoshihiro Shimoda
2010-05-07 9:35 ` Paul Mundt
2010-05-07 10:27 ` Yoshihiro Shimoda
2010-05-07 10:41 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100507104110.GH14009@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.