From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] 3.1.2 sensord duplicate RRD name problem
Date: Fri, 07 May 2010 12:42:07 +0000 [thread overview]
Message-ID: <20100507144207.2af40197@hyperion.delvare> (raw)
In-Reply-To: <25a99abe1003040437t333b4007k76850b406911925d@mail.gmail.com>
Hi Andre,
On Thu, 6 May 2010 21:42:30 +0200, Andre Prendel wrote:
> On Thu, May 06, 2010 at 06:12:52PM +0200, Jean Delvare wrote:
> > On Thu, 6 May 2010 14:20:56 +0200, Jean Delvare wrote:
> > > I have a patch ready, I'll give it some testing to make sure I got it
> > > right, and then I'll post it here.
> >
> > Andre, can you please comment on the patch below? Sergey, any chance
> > you could test it? It works for me on two different machines, but I may
> > not have covered all possible cases.
>
> Jean, the patch works for me with two sensor chips :)
>
> So I think it's enough for the moment.
I've committed the patch, thank you. Hans, Aurelien, you probably want
to backport the fix to the Fedora and Debian packages if you are using
version 3.1.2 already:
http://www.lm-sensors.org/changeset/5835
> I've just realised that the code is
> still difficult to read. I hope we will find some time for more
> simplification/cleanups.
This would be very welcome. There has to be a way to come up with more
simple, less likely to break code.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-05-07 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 12:37 [lm-sensors] 3.1.2 sensord duplicate RRD name problem Sergey Kvachonok
2010-05-06 8:34 ` Jean Delvare
2010-05-06 11:54 ` Andre Prendel
2010-05-06 12:20 ` Jean Delvare
2010-05-06 16:12 ` Jean Delvare
2010-05-06 19:42 ` Andre Prendel
2010-05-07 12:42 ` Jean Delvare [this message]
2010-05-08 18:19 ` Sergey Kvachonok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100507144207.2af40197@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.