From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
"containers@lists.osdl.org" <containers@lists.osdl.org>,
Paul Menage <menage@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Vivek Goyal <vgoyal@redhat.com>,
Gui Jianfeng <GuiJianfeng@cn.fujitsu.com>
Subject: Re: [PATCH 5/5] blk-cgroup: Fix an RCU warning in blkiocg_create()
Date: Fri, 7 May 2010 07:55:15 -0700 [thread overview]
Message-ID: <20100507145515.GA2368@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100507065741.GW27497@kernel.dk>
On Fri, May 07, 2010 at 08:57:41AM +0200, Jens Axboe wrote:
> On Fri, May 07 2010, Li Zefan wrote:
> > Paul E. McKenney wrote:
> > > On Thu, Apr 22, 2010 at 05:32:28PM +0800, Li Zefan wrote:
> > >> with CONFIG_PROVE_RCU=y, a warning can be triggered:
> > >>
> > >> # mount -t cgroup -o blkio xxx /mnt
> > >> # mkdir /mnt/subgroup
> > >>
> > >> ...
> > >> kernel/cgroup.c:4442 invoked rcu_dereference_check() without protection!
> > >> ...
> > >>
> > >> To fix this, we avoid caling css_depth() here, which is a bit simpler
> > >> than the original code.
> > >
> > > Queued for 2.6.34, thank you!
> > >
> >
> > Seems neither you nor Jens queued this patch...
>
> I've included it now, thanks.
<red face> Thank you both for catching this one!!!
Thanx, Paul
next prev parent reply other threads:[~2010-05-07 14:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 9:29 [PATCH 1/5] cgroup: Fix an RCU warning in cgroup_path() Li Zefan
2010-04-22 9:30 ` [PATCH 2/5] cgroup: Fix an RCU warning in alloc_css_id() Li Zefan
2010-04-22 19:55 ` Paul E. McKenney
2010-04-22 9:30 ` [PATCH 3/5] sched: Fix an RCU warning in print_task() Li Zefan
2010-04-22 10:20 ` Peter Zijlstra
2010-04-22 21:12 ` Matt Helsley
2010-04-22 22:05 ` Paul E. McKenney
2010-04-22 19:56 ` Paul E. McKenney
2010-04-22 9:31 ` [PATCH 4/5] freezer cgroup: Fix an RCU warning in cgroup_freezing_or_frozen() Li Zefan
2010-04-22 12:27 ` Peter Zijlstra
2010-04-22 19:59 ` Paul E. McKenney
2010-04-22 19:59 ` Paul E. McKenney
2010-04-22 20:08 ` Peter Zijlstra
2010-04-23 1:05 ` Li Zefan
2010-04-23 6:47 ` Peter Zijlstra
2010-04-22 9:32 ` [PATCH 5/5] blk-cgroup: Fix an RCU warning in blkiocg_create() Li Zefan
2010-04-22 14:31 ` Vivek Goyal
[not found] ` <4BD017AC.1020209-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-04-22 19:57 ` Paul E. McKenney
2010-04-22 19:57 ` Paul E. McKenney
2010-05-07 6:56 ` Li Zefan
2010-05-07 6:57 ` Jens Axboe
2010-05-07 14:55 ` Paul E. McKenney [this message]
2010-04-22 19:55 ` [PATCH 1/5] cgroup: Fix an RCU warning in cgroup_path() Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100507145515.GA2368@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=GuiJianfeng@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.