From: Wei Wang2 <wei.wang2@amd.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] svm: Avoid VINTR injection during NMI shadow
Date: Fri, 7 May 2010 16:41:49 +0200 [thread overview]
Message-ID: <201005071641.50013.wei.wang2@amd.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
Hi,
I had observed that if xen injects and intercepts VINTR during NMI shadow, and
if the xen injects NMI into guest at a very hight frequency, guest vcpu will
hang. Attached patch avoids VINTR injection when guest is handling a NMI.
Thanks,
Wei
Signed-off-by: Wei Wang <wei.wang2@amd.com>
Reviewed-by: Wei Huang<wei.huang2@amd.com>
--
Legal Information:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34
85609 Dornach b. München
Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis München
Registergericht München, HRB Nr. 43632
[-- Attachment #2: fix_nmi.patch --]
[-- Type: text/x-diff, Size: 565 bytes --]
diff -r e6f751ed8e38 xen/arch/x86/hvm/svm/intr.c
--- a/xen/arch/x86/hvm/svm/intr.c Tue Mar 09 10:00:37 2010 +0000
+++ b/xen/arch/x86/hvm/svm/intr.c Fri May 07 16:15:58 2010 +0200
@@ -92,6 +92,10 @@ static void enable_intr_window(struct vc
* track 'NMI blocking' from NMI injection until IRET. This can be done
* quite easily in software by intercepting the unblocking IRET.
*/
+
+ if ( vmcb->general1_intercepts & GENERAL1_INTERCEPT_IRET )
+ return;
+
intr = vmcb->vintr;
intr.fields.irq = 1;
intr.fields.vector = 0;
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next reply other threads:[~2010-05-07 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 14:41 Wei Wang2 [this message]
2010-05-07 16:56 ` [PATCH] svm: Avoid VINTR injection during NMI shadow Keir Fraser
2010-05-07 17:18 ` Wei Wang2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005071641.50013.wei.wang2@amd.com \
--to=wei.wang2@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.