From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 6/6] quota: check error code from dquot_initialize Date: Fri, 7 May 2010 19:01:02 +0200 Message-ID: <20100507170102.GI3700@quack.suse.cz> References: <1270749865-25441-1-git-send-email-dmonakhov@openvz.org> <1270749865-25441-2-git-send-email-dmonakhov@openvz.org> <1270749865-25441-3-git-send-email-dmonakhov@openvz.org> <1270749865-25441-4-git-send-email-dmonakhov@openvz.org> <1270749865-25441-5-git-send-email-dmonakhov@openvz.org> <1270749865-25441-6-git-send-email-dmonakhov@openvz.org> <1270749865-25441-7-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, hch@infradead.org, sandeen@redhat.com To: Dmitry Monakhov Return-path: Received: from cantor2.suse.de ([195.135.220.15]:56558 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753324Ab0EGRBF (ORCPT ); Fri, 7 May 2010 13:01:05 -0400 Content-Disposition: inline In-Reply-To: <1270749865-25441-7-git-send-email-dmonakhov@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu 08-04-10 22:04:25, Dmitry Monakhov wrote: > In most places quota initialization error may be handled trivially. > But xxx_delete_inode is another story. It can not fail. > So we may just print error and continue. > > > NOTE: Filesystem which has ondisk orphan list may add such quotaless > inodes to the list to let fsck to handle it later. > But still, if inode hasn't quota initialized at the moment of > ->delete_inode() is definite sign of quota corruption so full > fsck, quotacheck is probably required. Please split this to per-fs patches. They can be merged through fs-specific trees and can get review from respective filesystem maintainers. Honza -- Jan Kara SUSE Labs, CR