From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Date: Fri, 07 May 2010 16:03:41 +0000 Subject: Re: [lm-sensors] [patch]hp_accel: Fix race in device removal Message-Id: <201005071803.41668.oneukum@suse.de> List-Id: References: <201005071747.40801.oneukum@suse.de> <20100507175401.3099fdef@hyperion.delvare> In-Reply-To: <20100507175401.3099fdef@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jean Delvare Cc: Andrew Morton , Eric Piel , Pavel Herrmann , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, Pavel Machek , stable@kernel.org Am Freitag, 7. Mai 2010 17:54:01 schrieb Jean Delvare: > Hi Oliver, > > On Fri, 7 May 2010 17:47:40 +0200, Oliver Neukum wrote: > > From 64a9e0d8e585c65526248e6cf1659a13fb01a93a Mon Sep 17 00:00:00 2001 > > From: Oliver Neukum > > Date: Fri, 7 May 2010 17:41:59 +0200 > > Subject: [PATCH] hp_accel: Fix race in device removal > > > > The work queue has to be flushed after the device has been made > > inaccessible. > > > > Signed-off-by: Oliver Neukum > > --- > > drivers/hwmon/hp_accel.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c > > index c8ab505..6f6e05d 100644 > > --- a/drivers/hwmon/hp_accel.c > > +++ b/drivers/hwmon/hp_accel.c > > @@ -328,9 +328,9 @@ static int lis3lv02d_remove(struct acpi_device *device, int type) > > lis3lv02d_joystick_disable(); > > lis3lv02d_poweroff(&lis3_dev); > > > > - flush_work(&hpled_led.work); > > led_classdev_unregister(&hpled_led.led_classdev); > > - > > + flush_work(&hpled_led.work); > > + > > return lis3lv02d_remove_fs(&lis3_dev); > > } > > > > You are adding trailing white space. Please don't. Use > scripts/checkpatch.pl to check your patches before you send them. Thank you. A corrected version is on its way. Regards Oliver _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756686Ab0EGQD5 (ORCPT ); Fri, 7 May 2010 12:03:57 -0400 Received: from cantor.suse.de ([195.135.220.2]:52879 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752517Ab0EGQD4 (ORCPT ); Fri, 7 May 2010 12:03:56 -0400 From: Oliver Neukum Organization: SUSE To: Jean Delvare Subject: Re: [lm-sensors] [patch]hp_accel: Fix race in device removal Date: Fri, 7 May 2010 18:03:41 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.34-rc6-0.1-default; KDE/4.3.5; x86_64; ; ) Cc: Andrew Morton , Eric Piel , Pavel Herrmann , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, Pavel Machek , stable@kernel.org References: <201005071747.40801.oneukum@suse.de> <20100507175401.3099fdef@hyperion.delvare> In-Reply-To: <20100507175401.3099fdef@hyperion.delvare> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005071803.41668.oneukum@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 7. Mai 2010 17:54:01 schrieb Jean Delvare: > Hi Oliver, > > On Fri, 7 May 2010 17:47:40 +0200, Oliver Neukum wrote: > > From 64a9e0d8e585c65526248e6cf1659a13fb01a93a Mon Sep 17 00:00:00 2001 > > From: Oliver Neukum > > Date: Fri, 7 May 2010 17:41:59 +0200 > > Subject: [PATCH] hp_accel: Fix race in device removal > > > > The work queue has to be flushed after the device has been made > > inaccessible. > > > > Signed-off-by: Oliver Neukum > > --- > > drivers/hwmon/hp_accel.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c > > index c8ab505..6f6e05d 100644 > > --- a/drivers/hwmon/hp_accel.c > > +++ b/drivers/hwmon/hp_accel.c > > @@ -328,9 +328,9 @@ static int lis3lv02d_remove(struct acpi_device *device, int type) > > lis3lv02d_joystick_disable(); > > lis3lv02d_poweroff(&lis3_dev); > > > > - flush_work(&hpled_led.work); > > led_classdev_unregister(&hpled_led.led_classdev); > > - > > + flush_work(&hpled_led.work); > > + > > return lis3lv02d_remove_fs(&lis3_dev); > > } > > > > You are adding trailing white space. Please don't. Use > scripts/checkpatch.pl to check your patches before you send them. Thank you. A corrected version is on its way. Regards Oliver