From: Greg KH <greg@kroah.com>
To: Hank Janssen <hjanssen@microsoft.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Virtualization@lists.osdl.org" <Virtualization@lists.osdl.org>,
Ky Srinivasan <ksrinivasan@novell.com>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: Patch to auto-load MSFT PV NIC driver
Date: Sat, 8 May 2010 07:27:16 -0700 [thread overview]
Message-ID: <20100508142716.GA32133@kroah.com> (raw)
In-Reply-To: <8AFC7968D54FB448A30D8F38F259C5621AFFB3F9@TK5EX14MBXC114.redmond.corp.microsoft.com>
On Sat, May 08, 2010 at 01:52:01PM +0000, Hank Janssen wrote:
>
>
> >From: Ky Srinivasan [ksrinivasan@novell.com] - Friday, May 07, 2010 4:52 PM
> >
> > I am attaching a patch to auto-load hv_netvsc.
>
> I am not sure if this is the right approach. hv_netvsc takes a dependency on hv_vmbus.
> hv_vmbus does have the same DMI detection logic in it. But unless hv_vmbus has loaded
> up competely, hv_netvsc will fail on loadup. And I do not think we can guarantee that
> hv_vmbus has loaded yet.
Yes you can, the dependancies in the module will take care of it. Try
it, if you try to load the hv_netvsc module before hv_vmbus, modprobe
will load hv_vmbus first.
> It would be better to have netvsc check to make sure hv_vmbus is loaded.
How would you do that? The symbol resolution will not allow hv_netvsc
to be loaded without hv_vmbus being around.
Now I do think that just adding the same pci/dmi ids to all of the
modules is a bit odd, and that something else needs to be done here, but
at the moment, I can't think of anything better.
thanks,
greg k-h
next prev parent reply other threads:[~2010-05-08 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 23:52 Patch to auto-load MSFT PV NIC driver Ky Srinivasan
2010-05-08 13:52 ` Hank Janssen
2010-05-08 14:27 ` Greg KH [this message]
2010-05-08 23:02 ` Jeremy Fitzhardinge
2010-05-10 15:49 ` Greg KH
2010-05-10 17:05 ` Hank Janssen
2010-05-10 17:21 ` Greg KH
2010-05-11 13:55 ` Ky Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100508142716.GA32133@kroah.com \
--to=greg@kroah.com \
--cc=Virtualization@lists.osdl.org \
--cc=devel@driverdev.osuosl.org \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=ksrinivasan@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.