From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754839Ab0EJQRd (ORCPT ); Mon, 10 May 2010 12:17:33 -0400 Received: from smtp-outbound-1.vmware.com ([65.115.85.69]:8122 "EHLO smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752708Ab0EJQRa (ORCPT ); Mon, 10 May 2010 12:17:30 -0400 From: Dmitry Torokhov Organization: VMware, Inc. To: "H. Peter Anvin" Subject: Re: [tip:x86/cpu] Modify the VMware balloon driver for the new x86_hyper API Date: Mon, 10 May 2010 09:17:28 -0700 User-Agent: KMail/1.13.2 (Linux/2.6.34-rc5; KDE/4.4.2; x86_64; ; ) Cc: "mingo@redhat.com" , "linux-kernel@vger.kernel.org" , "greg@kroah.com" , "hjanssen@microsoft.com" , "ksrinivasan@novell.com" , "tglx@linutronix.de" , Alok Kataria , "linux-tip-commits@vger.kernel.org" References: <4BE49778.6060800@zytor.com> <201005100106.07156.dtor@vmware.com> <4BE824F0.3030301@zytor.com> In-Reply-To: <4BE824F0.3030301@zytor.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201005100917.28980.dtor@vmware.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 10 May 2010 08:23:28 am H. Peter Anvin wrote: > On 05/10/2010 01:06 AM, Dmitry Torokhov wrote: > > Source please? I was not aware that there was a standard governing > > returns code for module init methods. > > ENODEV means "not a device node." > ENXIO means "hardware not present." > There is no device node in question. Again, could you please point me to the list of allowed error codes for init methods? According to SUS, we need to follow ERROR section of the appropriate function, and I do not believe that spec covers cases if driver binding and module loading. FWIW -ENODEV is explicitly allowed in our device core and means "device not found", especially in context of platform devices. I do not see the need of changing that. Thanks. -- Dmitry