From: Russell King <rmk@arm.linux.org.uk>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: akpm@linux-foundation.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 0/6] remove unnecessary sync_single_range_* in dma_map_ops
Date: Mon, 10 May 2010 10:29:09 +0100 [thread overview]
Message-ID: <20100510092909.GA11675@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1272371140-6085-1-git-send-email-fujita.tomonori@lab.ntt.co.jp>
On Tue, Apr 27, 2010 at 09:25:34PM +0900, FUJITA Tomonori wrote:
> This patchset removes useless sync_single_range_for_cpu and
> sync_single_range_for_device hooks in dma_map_ops. These hooks were
> for dma_sync_single_range_* DMA API, however, the API became obsolete
> (the description in DMA API docs was removed too). Architecutres
> should use sync_single_for_cpu and sync_single_for_device hooks
> instead (as DMA API docs say, they need to support a partial sync).
If you're going to do this, then please catch all instances - compare
the number of places which contain "dma_sync_single_range" with your
diffstat and you'll notice you've missed a _lot_ of places.
$ git grep -l '\<dma_sync_single_range'
arch/arm/include/asm/dma-mapping.h
arch/avr32/include/asm/dma-mapping.h
arch/blackfin/include/asm/dma-mapping.h
arch/cris/include/asm/dma-mapping.h
arch/frv/include/asm/dma-mapping.h
arch/m68k/include/asm/dma-mapping.h
arch/mips/include/asm/dma-mapping.h
arch/mips/mm/dma-default.c
arch/mn10300/include/asm/dma-mapping.h
arch/parisc/include/asm/dma-mapping.h
arch/xtensa/include/asm/dma-mapping.h
include/asm-generic/dma-mapping-broken.h
include/asm-generic/dma-mapping-common.h
include/linux/ssb/ssb.h
vs.
> arch/ia64/kernel/pci-swiotlb.c | 2 -
> arch/powerpc/kernel/dma-swiotlb.c | 4 +-
> arch/powerpc/kernel/dma.c | 12 +++++-----
> arch/x86/kernel/pci-swiotlb.c | 2 -
> include/asm-generic/dma-mapping-common.h | 20 +-----------------
> include/linux/dma-mapping.h | 10 ---------
> include/linux/swiotlb.h | 10 ---------
> lib/swiotlb.c | 31 ------------------------------
> 8 files changed, 10 insertions(+), 81 deletions(-)
It seems there's users of this API in linux/ssb/ssb.h.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2010-05-10 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 12:25 [PATCH -mm 0/6] remove unnecessary sync_single_range_* in dma_map_ops FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 1/6] dma-mapping: fix dma_sync_single_range_* FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 2/6] ia64: remove unnecessary sync_single_range_* in swiotlb_dma_ops FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 3/6] x86: " FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 4/6] powerpc: " FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 5/6] swiotlb: remove unnecessary swiotlb_sync_single_range_* FUJITA Tomonori
2010-04-27 12:25 ` [PATCH -mm 6/6] dma-mapping: remove unnecessary sync_single_range_* in dma_map_ops FUJITA Tomonori
2010-04-27 17:07 ` [LKML] [PATCH -mm 0/6] " Konrad Rzeszutek Wilk
2010-05-10 9:29 ` Russell King [this message]
2010-05-10 9:49 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510092909.GA11675@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.