From: Christoph Hellwig <hch@lst.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] cow: stop using mmap
Date: Mon, 10 May 2010 12:46:11 +0200 [thread overview]
Message-ID: <20100510104611.GA3871@lst.de> (raw)
In-Reply-To: <4BE7D4BB.5050205@redhat.com>
On Mon, May 10, 2010 at 11:41:15AM +0200, Kevin Wolf wrote:
> For one, there is a typo in the variable name, and also this is a void
> function which shouldn't return anything. The caller still seems to use
> the return value. Should probably stay an int function.
Yes, this was missing a quilt refresh after fixing that and running
QA..
next prev parent reply other threads:[~2010-05-10 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 15:16 [Qemu-devel] [PATCH 0/3] cow conversion to the block API Christoph Hellwig
2010-05-07 15:17 ` [Qemu-devel] [PATCH 1/3] cow: use pread/pwrite Christoph Hellwig
2010-05-07 15:17 ` [Qemu-devel] [PATCH 2/3] cow: stop using mmap Christoph Hellwig
2010-05-10 9:41 ` Kevin Wolf
2010-05-10 10:46 ` Christoph Hellwig [this message]
2010-05-07 15:17 ` [Qemu-devel] [PATCH 3/3] cow: use qemu block API Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2010-06-07 10:06 [Qemu-devel] [PATCH 2/3] cow: stop using mmap Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510104611.GA3871@lst.de \
--to=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.