From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: Page flipping not working as expected for compositing - engineering resource available to help fix it Date: Mon, 10 May 2010 11:00:49 -0700 Message-ID: <20100510110049.2eeff2f3@virtuousgeek.org> References: <201005071407.48208.simon.farnsworth@onelan.com> <201005101204.54591.simon.farnsworth@onelan.com> <201005101759.16910.simon.farnsworth@onelan.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from outbound-mail-01.bluehost.com (cpoproxy1-pub.bluehost.com [69.89.21.11]) by gabe.freedesktop.org (Postfix) with SMTP id 762949E76A for ; Mon, 10 May 2010 11:01:20 -0700 (PDT) In-Reply-To: <201005101759.16910.simon.farnsworth@onelan.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Simon Farnsworth Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 10 May 2010 17:59:16 +0100 Simon Farnsworth wrote: > On Monday 10 May 2010, Simon Farnsworth wrote: > > On Friday 7 May 2010, Simon Farnsworth wrote: > > > I've attached my test program (it's based on our C++ OpenGL compositor, > > > but cut down to just test OpenGL pageflipping) as performance.c, and my > > > test X stack's Xorg.0.log after one run of "performance -indirect" > > > (which ran for 573 frames). I'm using a 32-bit PAE kernel - I can add > > > information as required, and I'm happy to run tests or experiments for > > > people. > > > > > > 2) How should I go about fixing compositing? Should I fix indirect > > > rendering to use pageflipping (and if so, where do I start looking for > > > the code that's getting it wrong), or should I make TFP work when direct > > > rendering (and again, where should I start looking)? > > > > Is this the expected behaviour when indirect rendering? If so, I'll dive > > back into the stack and see if I can work out why TFP and direct rendering > > don't interact nicely. If not, roughly where should I look to fix it? > > I've found why direct rendering and TFP don't interact nicely, and it's a > client side error. > > Briefly, my compositor was being started as our signage user, who does not have > access to /dev/dri/card0, so was falling back to swrast. When you're using > swrast, TFP only appears to work for pixmaps you create, not for compositing > pixmaps. > > Sorry for the noise, What about the indirect bug? Did that also go away when you fixed the perms issue? If not, that sounds like a serious issue, in indirect mode the swap interval should still be honored I think... -- Jesse Barnes, Intel Open Source Technology Center