From: Jens Axboe <jens.axboe@oracle.com>
To: wzt.wzt@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Block: Check major number before allocate the buffer in register_blkdev()
Date: Mon, 10 May 2010 13:56:42 +0200 [thread overview]
Message-ID: <20100510115642.GB27497@kernel.dk> (raw)
In-Reply-To: <20100510061602.GB2858@localhost.localdomain>
On Mon, May 10 2010, wzt.wzt@gmail.com wrote:
> Check major number before allocate the buffer, if the major number is not exist,
> and the register_blkdev() called many times, kmalloc()/kfree() will be no need
> to invoked many times. So check the major number before use kmalloc() to allocate
> the buffer will be better.
This would generally be sound advice for performance oriented code, but
I can't see it making any difference here.
--
Jens Axboe
next prev parent reply other threads:[~2010-05-10 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 6:16 [PATCH] Block: Check major number before allocate the buffer in register_blkdev() wzt.wzt
2010-05-10 11:56 ` Jens Axboe [this message]
2010-05-10 12:24 ` wzt wzt
2010-05-10 12:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510115642.GB27497@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wzt.wzt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.