From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 2/6] gatchat: Add g_at_chat_send_full.
Date: Mon, 10 May 2010 14:13:09 -0500 [thread overview]
Message-ID: <201005101413.09271.denkenz@gmail.com> (raw)
In-Reply-To: <1273192031-11189-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3230 bytes --]
Hi Andrew,
> g_at_chat_send_full takes two additional parameters compared to
> g_at_chat_send. The destroy notification is removed from
> g_at_chat_send and users updated.
> ---
You stated earlier that the modem will return an error and not time out. If
this is the case then I'm really failing to see the point of needing the
submit callback. Perhaps we should simply drop this for now and assume that
all modems will return an error and not time out.
> drivers/atmodem/call-barring.c | 6 +-
> drivers/atmodem/call-forwarding.c | 4 +-
> drivers/atmodem/call-meter.c | 19 ++++----
> drivers/atmodem/call-settings.c | 12 +++---
> drivers/atmodem/call-volume.c | 13 ++----
> drivers/atmodem/cbs.c | 8 ++--
> drivers/atmodem/devinfo.c | 8 ++--
> drivers/atmodem/gprs-context.c | 6 +-
> drivers/atmodem/gprs.c | 16 ++++----
> drivers/atmodem/network-registration.c | 70
> +++++++++++++----------------- drivers/atmodem/phonebook.c |
> 16 ++++----
> drivers/atmodem/sim-poll.c | 5 +-
> drivers/atmodem/sim.c | 26 ++++++------
> drivers/atmodem/sms.c | 52 ++++++++++-------------
> drivers/atmodem/ssn.c | 2 +-
> drivers/atmodem/stk.c | 9 ++--
> drivers/atmodem/ussd.c | 6 +-
> drivers/atmodem/voicecall.c | 35 +++++++---------
> drivers/calypsomodem/voicecall.c | 7 +--
> drivers/hfpmodem/call-volume.c | 4 +-
> drivers/hfpmodem/network-registration.c | 13 +++---
> drivers/hfpmodem/voicecall.c | 27 ++++++------
> drivers/hsomodem/gprs-context.c | 11 ++---
> drivers/mbmmodem/gprs-context.c | 20 ++++----
> drivers/stemodem/gprs-context.c | 10 ++--
> drivers/stemodem/voicecall.c | 10 ++--
> gatchat/gatchat.c | 45 ++++++++++++++------
> gatchat/gatchat.h | 23 +++++++++-
> gatchat/gatmux.c | 4 +-
> gatchat/gsmdial.c | 31 ++++++--------
> plugins/calypso.c | 17 +++----
> plugins/em770.c | 8 +--
> plugins/g1.c | 6 +-
> plugins/hfp.c | 14 +++----
> plugins/hso.c | 8 ++--
> plugins/huawei.c | 8 +--
> plugins/mbm.c | 12 +++---
> plugins/novatel.c | 6 +--
> plugins/palmpre.c | 8 +--
> plugins/phonesim.c | 10 ++---
> plugins/ste.c | 7 +--
> unit/test-caif.c | 2 +-
> unit/test-mux.c | 18 ++++----
> 43 files changed, 313 insertions(+), 329 deletions(-)
Please separate these patches into:
- core GAtChat changes
- GAtChat utilities changes
- plugins changes
- drivers changes
- unit test changes
Regards,
-Denis
next prev parent reply other threads:[~2010-05-10 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 0:27 [PATCH v2 2/6] gatchat: Add g_at_chat_send_full Andrzej Zaborowski
2010-05-10 19:13 ` Denis Kenzior [this message]
2010-05-10 22:45 ` Andrzej Zaborowski
2010-05-10 23:48 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005101413.09271.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.