From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Robert Richter <robert.richter@amd.com>,
Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
Roland McGrath <roland@redhat.com>,
DLE <dle-develop@lists.sourceforge.net>
Subject: Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old
Date: Mon, 10 May 2010 16:15:01 -0300 [thread overview]
Message-ID: <20100510191501.GC19192@ghostprotocols.net> (raw)
In-Reply-To: <4BE8571E.4020403@redhat.com>
Em Mon, May 10, 2010 at 02:57:34PM -0400, Masami Hiramatsu escreveu:
> Hmm, ok, version.h is also introduced at the same time.
>
> # git log ./config/version.h.in
> commit fbc7245df72ce0142f0a21fa0f4f88c97278bf60
> Author: Roland McGrath <roland@redhat.com>
> Date: Tue Dec 16 17:03:03 2008 -0800
>
> Install elfutils/version.h header for library compatibility checking.
>
> So, I think we'd better set NO_DWARF if the elfutils
> is older than 0.138, since we can't check API compatibility
> easily.
Well, for that you can just add some of the code you ifdefed in this
patch into the tools/perf/Makefile test, or better, duplicate the test,
including just the CPI stuff in the new test, and then set NO_DWARF_CFI
and use it as the ifdef condition :-)
- Arnaldo
next prev parent reply other threads:[~2010-05-10 19:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 17:12 [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old Masami Hiramatsu
2010-05-10 17:28 ` Arnaldo Carvalho de Melo
2010-05-10 18:36 ` Robert Richter
2010-05-10 18:57 ` Arnaldo Carvalho de Melo
2010-05-10 18:57 ` Masami Hiramatsu
2010-05-10 19:15 ` Arnaldo Carvalho de Melo [this message]
2010-05-10 19:19 ` Masami Hiramatsu
2010-05-11 4:59 ` [PATCH -tip] perf probe: Check older elfutils and set NO_DWARF Masami Hiramatsu
2010-05-11 10:41 ` Robert Richter
2010-05-12 8:40 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-05-11 8:12 ` [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old Mark Wielaard
2010-05-18 1:57 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-05-18 9:35 ` Robert Richter
2010-05-18 9:39 ` Stephane Eranian
2010-05-18 10:18 ` Robert Richter
2010-05-18 14:03 ` acme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510191501.GC19192@ghostprotocols.net \
--to=acme@infradead.org \
--cc=dle-develop@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=roland@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.