All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Anton Blanchard <anton@samba.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panic: Call console_verbose in panic
Date: Mon, 10 May 2010 16:10:58 -0700	[thread overview]
Message-ID: <20100510231058.GA19546@suse.de> (raw)
In-Reply-To: <20100510225959.GC12203@kryten>

On Tue, May 11, 2010 at 08:59:59AM +1000, Anton Blanchard wrote:
> 
> Most distros turn the console verbosity down and that means a backtrace after
> a panic never makes it to the console. I assume we haven't seen this because
> a panic is often preceeded by an oops which will have called console_verbose.
> There are however a lot of places we call panic directly, and they are
> broken.
> 
> Use console_verbose like we do in the oops path to ensure a directly called
> panic will print a backtrace.
> 
> Signed-off-by: Anton Blanchard <anton@samba.org>

Looks good to me:
	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>

thanks,

greg k-h

  reply	other threads:[~2010-05-10 23:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-10 22:59 [PATCH] panic: Call console_verbose in panic Anton Blanchard
2010-05-10 23:10 ` Greg KH [this message]
2010-05-12 23:39 ` Andrew Morton
2010-05-13 10:00   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100510231058.GA19546@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.