From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Len Brown <lenb@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [git pull request] ACPI patches for 2.6.34-rc6
Date: Tue, 11 May 2010 18:25:43 +0100 [thread overview]
Message-ID: <20100511172543.GA17868@srcf.ucam.org> (raw)
In-Reply-To: <20100507213600.GC28906@srcf.ucam.org>
On Fri, May 07, 2010 at 10:36:00PM +0100, Matthew Garrett wrote:
> On Fri, May 07, 2010 at 02:21:08PM -0700, Linus Torvalds wrote:
> > Well, is there any reason to have 'set_sci_en_on_resume' at all then?
>
> I'd hope not, but it depends on what Windows does on resume. If it
> doesn't do the SMM call and just does the register write instead, then
> it may be that some machines are on that list because the SMM call
> breaks them rather than because they need the register to be set by
> hand. I'm planning on instrumenting it to check, but haven't had time to
> do so yet.
I've now checked the behaviour of Windows. It turns out that it never
makes the ACPI enable SMM call on resume. This is consistent with
http://bugzilla.kernel.org/show_bug.cgi?id=13745 which shows a bug
being introduced by us making the enable call in the first place.
Merging my patch and removing the blacklist would re-break these
machines. Instead, we should just unconditionally set SCI_EN since this
is the tested configuration. I'll send a followup patch.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-05-11 17:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 2:22 [git pull request] ACPI patches for 2.6.34-rc6 Len Brown
2010-05-07 2:34 ` Linus Torvalds
2010-05-07 6:12 ` Matthew Garrett
2010-05-07 21:06 ` Linus Torvalds
2010-05-07 21:13 ` Matthew Garrett
2010-05-07 21:21 ` Linus Torvalds
2010-05-07 21:36 ` Matthew Garrett
2010-05-11 17:25 ` Matthew Garrett [this message]
2010-05-11 17:42 ` Linus Torvalds
2010-05-11 17:59 ` Matthew Garrett
2010-05-11 18:17 ` Linus Torvalds
2010-05-11 18:22 ` Matthew Garrett
2010-05-12 16:07 ` Robert Wörle
2010-05-12 16:12 ` Matthew Garrett
2010-05-07 22:39 ` Rafael J. Wysocki
2010-05-07 23:00 ` Linus Torvalds
2010-05-07 23:17 ` Rafael J. Wysocki
2010-05-07 23:21 ` Linus Torvalds
2010-05-08 0:03 ` Rafael J. Wysocki
2010-05-08 0:10 ` Linus Torvalds
2010-05-08 5:19 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100511172543.GA17868@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.